Message-ID: <ae33b33e-1581-27ac-10bf-b4fab7c3c418@pgmasters.net>
Date: Fri, 7 Jan 2022 08:51:14 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Content-Language: en-US
To: Euler Taveira <euler@eulerto.com>, "Bossart, Nathan"
 <bossartn@amazon.com>, Andrew Dunstan <andrew@dunslane.net>,
 Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>,
 Laurenz Albe <laurenz.albe@cybertec.at>,
 Michael Paquier <michael@paquier.xyz>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
References: <CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com>
 <YaB3Oj4GfPOZ/3LC@paquier.xyz> <417711.1637940660@sss.pgh.pa.us>
 <20211130142042.GR26257@tamriel.snowman.net>
 <3404870c1a921bafbcd168c098088981fe082ab1.camel@cybertec.at>
 <CAOuzzgoYqzH+c_fzapjGFh6kiZjXDc0jPCQctbQjajn7a4vyxA@mail.gmail.com>
 <845544A4-0B0E-41D2-903C-C8B9E8A18812@amazon.com>
 <1661037.1638311167@sss.pgh.pa.us>
 <1cce9981-2c48-981a-a936-812830dfb3b1@pgmasters.net>
 <BC31E8F0-7CFF-462E-9B27-727AD573A675@amazon.com>
 <9427c6b3-5e0b-e27f-a2e7-ec1ebc00b582@pgmasters.net>
 <AC0ADAC3-E196-42A0-9471-A22F966E1A5F@amazon.com>
 <E87F96A8-9DBD-4E8D-8EE9-A03B4F126119@amazon.com>
 <4a363c5a-473f-9cb9-9f59-74a230575340@dunslane.net>
 <553d2348-1015-3546-2be8-b5a8a745dfa8@pgmasters.net>
 <df3f0f28-4023-0c1a-dbc4-a92804e78054@pgmasters.net>
 <BA0B4F94-92C4-470B-81BC-4922A4668B34@amazon.com>
 <E2995C0D-9F02-430D-A787-E3A77FA914F9@amazon.com>
 <816909aa-8772-4cfb-897f-6c75b9ce618c@www.fastmail.com>
From: David Steele <david@pgmasters.net>
In-Reply-To: <816909aa-8772-4cfb-897f-6c75b9ce618c@www.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/ae33b33e-1581-27ac-10bf-b4fab7c3c418%40pgmasters.net>
Precedence: bulk

On 1/6/22 20:20, Euler Taveira wrote:
> On Thu, Jan 6, 2022, at 9:48 PM, Bossart, Nathan wrote:
>> After a quick glance, I didn't see an easy way to hold a session open
>> while the test does other things.  If there isn't one, modifying
>> backup_fs_hot() to work with non-exclusive mode might be more trouble
>> than it is worth.
 >
> You can use IPC::Run to start psql in background. See examples in
> src/test/recovery.

I don't think updating backup_fs_hot() is worth it here.

backup_fs_cold() works just fine for this case and if there is a need 
for backup_fs_hot() in the future it can be implemented as needed.

Regards,
-David