Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wIWzz-008BBj-1W for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Apr 2026 19:24:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wIWzy-008ak8-1B for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Apr 2026 19:24:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wIWzx-008ajz-39 for pgsql-hackers@lists.postgresql.org; Thu, 30 Apr 2026 19:24:34 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wIWzv-000000044rs-2R9k for pgsql-hackers@postgresql.org; Thu, 30 Apr 2026 19:24:33 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 63FA45DC1E0 for ; Thu, 30 Apr 2026 21:24:30 +0200 (CEST) Received: from s981.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 4DFC35DB770; Thu, 30 Apr 2026 21:24:30 +0200 (CEST) Received: from localhost (unknown [172.22.191.6]) by s981.loopia.se (Postfix) with ESMTP id 4A7AD22B168B; Thu, 30 Apr 2026 21:24:30 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s471.loopia.se (amavis); dkim=pass (2048-bit key) header.d=proxel.se Received: from s979.loopia.se ([172.22.191.6]) by localhost (s471.loopia.se [172.22.190.35]) (amavis, port 10024) with LMTP id Wtk9c5rAupsc; Thu, 30 Apr 2026 21:24:29 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: andreas@proxel.se X-Loopia-Originating-IP: 147.28.75.140 Received: from [192.168.0.186] (customer-147-28-75-140.stosn.net [147.28.75.140]) (Authenticated sender: andreas@proxel.se) by s979.loopia.se (Postfix) with ESMTPSA id A359610BC3AB; Thu, 30 Apr 2026 21:24:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxel.se; s=loopiadkim1707418970; t=1777577069; bh=NjQLjXNgaXAMq6is+10P3G/GWEYlrMvM302qGkPxZwg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=maFZ2QmnFDH6VZUC/79nwYmj3xY8fSs7cfTp43iXqZ9Qo8RgkZBJ6iCjDaTcZiqiW NYbRmGU0peCRsDNVRJByjTzzarG2Je30W11LmOqkwEFPcNA1hXAw5QQ3JeuI7XOPGT QFW5qGGuWwni7jIrZNr0NrLYBGH4d3MFWobFLRiQ+uGSpuZ9b/JllQXYqoNrx6L130 R4D3F8Oee22UyehBwOe7Tf+Sco7ZzxF28o51Lg7hgu78iRexI42/RBetFYoIWzcxEo u2VThct2ssShy2b/7xmpdahhm6UPuqHOeiEZVYE1dqjpSx13zdMUpPZ+T+iVVYDEym inI+uIVPXLWTA== Content-Type: multipart/mixed; boundary="------------M2qYxx0wtxf63FNhHGnq45Hk" Message-ID: Date: Thu, 30 Apr 2026 21:24:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Add editorconfig support for Postgres spec files To: Jelte Fennema-Nio , Heikki Linnakangas Cc: Tristan Partin , pgsql-hackers References: <29230792-69b4-473c-b2a7-7801bc8769e0@iki.fi> Content-Language: en-US From: Andreas Karlsson In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------M2qYxx0wtxf63FNhHGnq45Hk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/17/26 22:10, Jelte Fennema-Nio wrote: > I think in any case that script should be update to add some "DO NOT > MODIFY MANUALLY! GENERATED USING src/tools/generate_editorconfig.py " > header to the resulting editorconfig file. Because I agree that's not > clear at the moment. You mean like this? I think the comment should point them towards the script which generated it. -- Andreas Karlsson Percona --------------M2qYxx0wtxf63FNhHGnq45Hk Content-Type: text/x-patch; charset=UTF-8; name="0001-Add-comment-clarifying-.editorconfig-is-generated.patch" Content-Disposition: attachment; filename*0="0001-Add-comment-clarifying-.editorconfig-is-generated.patch" Content-Transfer-Encoding: base64 RnJvbSA3MmU5YjVhYTMyMzc1NmMxZDFiMzBiNTk3YTllNWE1N2RhMjI3OTI4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZWFzIEthcmxzc29uIDxhbmRyZWFzLmthcmxz c29uQHBlcmNvbmEuY29tPgpEYXRlOiBUaHUsIDMwIEFwciAyMDI2IDIxOjE4OjI3ICswMjAw ClN1YmplY3Q6IFtQQVRDSF0gQWRkIGNvbW1lbnQgY2xhcmlmeWluZyAuZWRpdG9yY29uZmln IGlzIGdlbmVyYXRlZAoKVG8gbWFrZSBzdXJlIHBlb3BsZSBkbyBub3QgdHJ5IHRvIG1hbnVh bGx5IGVkaXQgLmVkaXRvcmNvbmZpZyBsZXQncyBhZGQKYSBjb21tZW50IG9uIHRvcCBvZiB0 aGUgZmlsZSBwb2ludGluZyB0aGVtIHRvd2FyZHMgd2hlcmUgdGhleSBjYW4gbGVhcm4KaG93 IHRvIGdlbmVyYXRlIGl0LgotLS0KIC5lZGl0b3Jjb25maWcgICAgICAgICAgICAgICAgICAg ICAgfCAyICsrCiBzcmMvdG9vbHMvZ2VuZXJhdGVfZWRpdG9yY29uZmlnLnB5IHwgNCArKyst CiAyIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhLy5lZGl0b3Jjb25maWcgYi8uZWRpdG9yY29uZmlnCmluZGV4IDBlZTliZDI4 YWM0Li4yNGQzZmRlYWU4MSAxMDA2NDQKLS0tIGEvLmVkaXRvcmNvbmZpZworKysgYi8uZWRp dG9yY29uZmlnCkBAIC0xLDMgKzEsNSBAQAorIyBHZW5lcmF0ZWQgYnkgc3JjL3Rvb2xzL2dl bmVyYXRlX2VkaXRvcmNvbmZpZy5weQorCiByb290ID0gdHJ1ZQogCiBbKl0KZGlmZiAtLWdp dCBhL3NyYy90b29scy9nZW5lcmF0ZV9lZGl0b3Jjb25maWcucHkgYi9zcmMvdG9vbHMvZ2Vu ZXJhdGVfZWRpdG9yY29uZmlnLnB5CmluZGV4IDBjZTU0ZjcyOTJhLi43ZWExZGNmNTQ0MiAx MDA3NTUKLS0tIGEvc3JjL3Rvb2xzL2dlbmVyYXRlX2VkaXRvcmNvbmZpZy5weQorKysgYi9z cmMvdG9vbHMvZ2VuZXJhdGVfZWRpdG9yY29uZmlnLnB5CkBAIC0yNSw3ICsyNSw5IEBAIGRl ZiBtYWluKCk6CiAgICAgd2l0aCBvcGVuKCIuZ2l0YXR0cmlidXRlcyIsICJyIikgYXMgZjoK ICAgICAgICAgbGluZXMgPSBmLnJlYWQoKS5zcGxpdGxpbmVzKCkKIAotICAgIG5ld19jb250 ZW50cyA9ICIiInJvb3QgPSB0cnVlCisgICAgbmV3X2NvbnRlbnRzID0gIiIiIyBHZW5lcmF0 ZWQgYnkgc3JjL3Rvb2xzL2dlbmVyYXRlX2VkaXRvcmNvbmZpZy5weQorCityb290ID0gdHJ1 ZQogCiBbKl0KIGluZGVudF9zaXplID0gdGFiCi0tIAoyLjQzLjAKCg== --------------M2qYxx0wtxf63FNhHGnq45Hk--