Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 27 Apr 2026 09:36:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: DaeMyung Kang <charsyam@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Fix memory leak of primary_sysid in walreceiver
Message-ID: <ae6vp9L-GUb0ERTF@paquier.xyz>
References: <20260426170219.849330-1-charsyam@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QaR6R2sIeSlUg6f8"
Content-Disposition: inline
In-Reply-To: <20260426170219.849330-1-charsyam@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ae6vp9L-GUb0ERTF%40paquier.xyz>
Precedence: bulk


--QaR6R2sIeSlUg6f8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 27, 2026 at 02:01:30AM +0900, DaeMyung Kang wrote:
> The attached patch adds a pfree(primary_sysid) right after the
> comparison.

My first impression was that it does not matter because I was under
the impression that this code path is only reached once, but that's
not the case: a WAL receiver could stay around waiting for
instructions before retrying a connection.

I doubt that this is worth bothering for in the back branches, as it
just means a small leak each time we switch to a new TLI repeatedly,
something that would matter mostly for a cascading standby where we
don't want to change the connection point (a SIGHUP'd primary_conninto
enforces a WAL receiver shutdown).  Let's clean up on HEAD, though.
--
Michael

--QaR6R2sIeSlUg6f8
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnur6cACgkQnvQgOdby
QH15zA//Vb3QgL+nrZ4ZHxcaQSkxXbYYCQGQP14wk0/XPjNVQq6QHUC+o87jb2Xe
aG+AW+He9M6h0zJxe8k1v8Dfx3kL7HukC8y76nP2ukBve9m3yDaLi5RzBhjtAW+8
eV7BPgph1W1yXisiex719WJwKk6j5/pA9gMrmBQCnje5Hn1MVZViFmsJ9PSeLN47
jiSZE3K5esAiGzu3eelrlbaiEn9/cILSvbrk4FdyGoe2MwkNIcgh5oNeHY3aoRxE
5gTmKEFspRg0+v4SGJz+lcrrj074ifIzrStKPTiyrQdf5+Skr4Tl60DemML8pOFZ
iI1DwsYmeGEkKg3fdTLk2RWA+G2Rzd28za42GAnkV4lJSg5/4cEuCU6WzaD2xaxn
wC9oT757Xo0NrZMrGPSe0cv4ZExkl/feQQSIcJGar72BnAy0vmcB+/DWUmsjBwFc
6pjMbzcyf3XVGKCPFvz7Vz9+kbyZVrQPxZC5s4WXwb3EnuODqSjCLPBpczQi5JRA
UvKOdYeCXeC+N/9fFbyDjb1v06hrb54jiziccKFx8n3eBojbwFZvI7CSNXnPAQoK
ju3HAObgUsYqJCuQITQVLATE2wNBYA6Eu0OyTCM0hJZxs+vTMfMvmT3YJoEoELG9
7bIYslxMboAxYcNUgFheqDSjwjNw/aeKoagGh/c5j2tZKhtRwQI=
=Blpp
-----END PGP SIGNATURE-----

--QaR6R2sIeSlUg6f8--