Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 27 Apr 2026 09:46:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: DaeMyung Kang <charsyam@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Fix memory leak of reply_message in walreceiver
Message-ID: <ae6xymlfUepxsT6n@paquier.xyz>
References: <20260426170100.847923-1-charsyam@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WI7CiYpRJr05weyx"
Content-Disposition: inline
In-Reply-To: <20260426170100.847923-1-charsyam@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ae6xymlfUepxsT6n%40paquier.xyz>
Precedence: bulk


--WI7CiYpRJr05weyx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 27, 2026 at 01:59:09AM +0900, DaeMyung Kang wrote:
> initStringInfo() unconditionally allocates a fresh ~1KB buffer with
> palloc() and overwrites the existing data pointer without freeing the
> previous one. So every time the walreceiver re-enters the streaming
> path -- e.g., after a timeline switch, end-of-WAL, or any other
> condition that drives the outer for(;;) loop to iterate -- the prior
> buffer is leaked. The leak is bounded per streaming restart but
> accumulates over the lifetime of a long-running standby that
> restarts streaming often.

This is a problem similar to [1], and I'd agree about cleaning that up
properly.

> This appears to date back to commit add6c3179a4 ("Make the streaming
> replication protocol messages architecture-independent.", 2012), so
> the fix is likely a candidate for back-patching to all supported
> branches.

This is minor, so I don't really see a point in back-patching.  Same
reason as the other thread.

I'll go merge that together.

[1]: https://www.postgresql.org/message-id/ae6vp9L-GUb0ERTF@paquier.xyz
--
Michael

--WI7CiYpRJr05weyx
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnuscoACgkQnvQgOdby
QH3ANA//YXZQMP2ZV077+XoIIEKSu4kVsEMsEGV+O2UKM2ZZM61hrW4rNDqfNU/o
2KoSbUh8Vie8ZBu9+Stw2JS2MVMSCZDsz66n4Rl6Dri87Icg7r2Las9+1OoCGgc/
BmN2IFegJke3+sx1Qqruwi5FQ0+NqfQOlW18sfK3/9laDPGNxA/KOVAVVd4Wy7TE
hgI8Yr46HqAFAW9D/slCvN0KgBjodhq78BO0xUqjPyVEWU4k5i9KcS0nDiCJ+6aC
PapyA3PgG9zSyRX15668XA1R1lPimOQk7lIQ1AxIkX9i5Is5+XiSpMQS0xZtFFj2
naTkxnRWjYfzDeMR0foxBMDZR8VMkhtQvVB/4h5EGfhs8LyBNpNmLyNus4iEc+3H
s5hfDwOP5ARiG8+71S7dYY8d6gPYs+5HfwxUZDwSZSDfJdAkAFE5D4upLXbLRbdN
SB3MLdh+gLZ9q9UPTIJs3ZLNPyVFZD+HM1+3BGj752j5ZKXXSaHsaEAULcmcArLJ
q5RR26CAXOZrOADHkF7y9yWX5vojJo5eLCKMwgysj/eoDtwsTqLfM0svtTJvI+3U
jyFnwkQtkVqPMiiV0QRzIyB45jvpx+eGVHKMqZ4J7K2FxVy78Q26mxCeBXMKgTPL
w5C0O+O1OfzWlv2EoCCg5mhyBjoOphn+eDwxVDNYUNJDCEMgAaQ=
=Iwly
-----END PGP SIGNATURE-----

--WI7CiYpRJr05weyx--