Message-ID: <ae73f6f5-8221-c112-4640-5cda812a69de@gmail.com>
Date: Thu, 28 Dec 2023 18:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: broken master regress tests
Content-Language: en-US
To: Jeff Davis <pgsql@j-davis.com>, Noah Misch <noah@leadboat.com>,
 Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Thomas Munro <thomas.munro@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CA+hUKG+VkcevnqLmbZSD4C5hJ3=TQWgMP-th8LqsbNt0TqZfqw@mail.gmail.com>
 <20230829155424.bem25upvaefkqqyy@alvherre.pgsql>
 <20230912022358.d5ln25sglrntwaia@awork3.anarazel.de>
 <0d47e5ecc037b3908149aad5f2a987793cf938bd.camel@j-davis.com>
 <20231011005434.34oc4v4pv6ajqkss@awork3.anarazel.de>
 <20231213025619.70.nmisch@google.com>
 <97c9d15247c5919b444b2e217b4c886271be0ea5.camel@j-davis.com>
 <c6571aac4c6da3e2f013fe74fcc95d6e052bf04c.camel@j-davis.com>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <c6571aac4c6da3e2f013fe74fcc95d6e052bf04c.camel@j-davis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/ae73f6f5-8221-c112-4640-5cda812a69de%40gmail.com>
Precedence: bulk

Hello Jeff,

22.12.2023 02:17, Jeff Davis wrote:
> On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
>> Attached.
> It appears to increase the coverage. I committed it and I'll see how
> the buildfarm reacts.

Starting from the commit 8793c6005, I observe a failure of test
collate.windows.win1252 on Windows Server 2016:
meson test regress/regress
1/1 postgresql:regress / regress/regress        ERROR 24.47s   exit status 1

regression.diffs contains:
@@ -993,6 +993,8 @@
  -- nondeterministic collations
  -- (not supported with libc provider)
  CREATE COLLATION ctest_det (locale = 'en_US', deterministic = true);
+ERROR:  could not create locale "en_US": No such file or directory
+DETAIL:  The operating system could not find any locale data for the locale name "en_US".
  CREATE COLLATION ctest_nondet (locale = 'en_US', deterministic = false);
  ERROR:  nondeterministic collations not supported with this provider
  -- cleanup

Though
CREATE COLLATION ctest_det (locale = 'English_United States', deterministic = true);
executed successfully on this OS.

AFAICS, before that commit SELECT getdatabaseencoding() in the test
returned SQL_ASCII, hence the test was essentially skipped, but now it
returns WIN1252, so problematic CREATE COLLATION(locale = 'en_US', ...)
is reached.

Best regards,
Alexander