Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wHF0q-006zHq-2y for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Apr 2026 06:00:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wHF0q-00CMqo-07 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Apr 2026 06:00:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wHF0p-00CMqf-0a for pgsql-hackers@lists.postgresql.org; Mon, 27 Apr 2026 06:00:07 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wHF0l-00000003HlD-2Wcz for pgsql-hackers@lists.postgresql.org; Mon, 27 Apr 2026 06:00:06 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id F38EB14000FD; Mon, 27 Apr 2026 01:59:59 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Mon, 27 Apr 2026 01:59:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1777269599; x=1777355999; bh=QCedkR4LpF 27fcJme3sziLreXGkC93U3NdnYbwKm3z8=; b=YEiarMMKlABi0a9gVlT+i8cQuW 9IROpsB6bl3wRgMRr8njFgGsEBV5oUm7lp45hIOCWC7hd00k6h+N5WKPlP3HR6bD xefSXFW0eyU9SBNUWTWji8X45cjFnqWjDu1gWzYKGhMTgTZzEKkL0MRGw1IxBto2 swASGocy8ZUkW5d2EGuejPq7jgDFu9YQ5Ldr66eZO8nkGMbyb5yUMRhpfpzGfsU/ ytM6eUCTxkGJx9i8I1L+WFS2sVSVgpgg1Eeo72g3kNwlRSYZEh9zLqBt8pkXoYPe t8Y81Z6fXgetUeIJchNz32Ra4xtyh7mDTNAvD8Z1dgEaFAUEPEQFeUb4n1kA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1777269599; x=1777355999; bh=QCedkR4LpF27fcJme3sziLreXGkC93U3Ndn YbwKm3z8=; b=PrA/3s9aiDIm/ZJqkumxH6BiCjKK8oeUbGojJbgYny9tL2mFkqJ Lwsj+dq6Y7KZ7dbGYhrdfhdsUaQReEyry8pnZDjFEeuEXvIkuyExHn0nrngf8O4o 8XmSnoCt71InQ5XNXm/X8jcfqrzzGbkNx+Va4ylgYAPMstnEKI+QSpMOvuPYgf4R aXuHKptq+XaikXjqY/LvapZq582nKhaglO5MOqt9O9Ac9t4feawQ7Nf1c7+0f0OE 3l+GNqQ+fl0NnBbg9vA1rGMU9z7LFI6wWMGAKqyIPv3qdyuiPJa9fosZK4nWAe98 WMeaFLneVSU5dO+gOq1MVvUXeheIA97k3Ag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdejjeeltdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmrghsrg hordhfuhhjihhisehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhjhheluddtkedthees ghhmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsth hsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Apr 2026 01:59:58 -0400 (EDT) Date: Mon, 27 Apr 2026 14:59:54 +0900 From: Michael Paquier To: Fujii Masao Cc: JoongHyuk Shin , pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lNLicDvXqRKIDynC" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --lNLicDvXqRKIDynC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 27, 2026 at 02:36:11PM +0900, Fujii Masao wrote: > With the proposed patch, however, both settings are ignored and > recovery starts with no target. That seems unexpected to me. If that's the case (not tested myself), agreed. -- Michael --lNLicDvXqRKIDynC Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnu+1oACgkQnvQgOdby QH0Epg//Tkbe6ldxdIxv8Bv/qVTH41PiN9FbRngDMAUB6FlqaZ5iA91BWKBIzG2y FE/G5GAv8/A7QdYrWy5pJSg765BeokU59XF+UW4QP27+QUp83CoU1S2vNPIrd5xg Ioe7rOMom7TFV6SwUbbpYPeC1eUFeQrATLE4dRgccG/X34l4Mt6WVjhWexTumtQg EawqgZfow1qzJUjdg83fS4JBEN68K8aBXJHbh7XzgB+rQlk42hEcEkbOAKqKFQ9E 4vyC5EhqNh0SX6nrRPHZud62XDsTD5lBMBLluf/n7UCek01BKnBfVMqde0tLRfcG URg609DnHnXlX4AN2R9KLcONAGXKvGlMmGerE2LSloXt7hZchKisefkgbek7wJSn Ywf40iUMV4RPFlc3GZ5rA8awXNOkgY18s2tgG/CiE6SU1zFookAP3nLzLIzOww0u M1J5NA6qd6HPij3u23wnAgHsnrOxb+wCt/L7I0WFmoz+1WkU5KuU0n6IavfpBqnj qs8GeDHz2a2Ggxmz0TsMwUqRcgGkBZ5lWEh8oam4V90xs2jfA6mrqI21JL6+bCR4 AhbYTkLxYqjnxxXfs69i7lpXhTF4yvQ90KOYxP2NxyWF5AeparGab79KHsUCXteG q4dWYXVsGytOhZgHGIHRwBcIXCC38Q1Rf2uLGOAVNnQ+g0be6Sk= =54Yy -----END PGP SIGNATURE----- --lNLicDvXqRKIDynC--