Date: Thu, 16 Apr 2026 11:31:27 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	Andres Freund <andres@anarazel.de>
Subject: Re: Make copyObject work in C++
Message-ID: <aeDIj2SBDl0EHZtb@bdtpg>
References: <5291d173-1227-4619-b8fd-62336ad292b3@eisentraut.org>
 <CAGECzQSB=rBZ2n1WeCRAQ09xHzHSpyVBk-+NWEAcLsegsRXPzA@mail.gmail.com>
 <6dff90f6-2afb-44a3-9524-b017924d71da@eisentraut.org>
 <DHFMW63NP35Z.3RRS8PIYV508K@jeltef.nl>
 <7ddb8894-3939-4846-8d7f-d886b2cb42ab@eisentraut.org>
 <CAGECzQRauVYN19Y-DTiCTCkdNabh+ZqhdaLrUHR6CAU4wm2TFQ@mail.gmail.com>
 <8f4a2a1e-6142-4481-bc21-76fd33419103@eisentraut.org>
 <adeQc3I/4dwpeqEb@ip-10-97-1-34.eu-west-3.compute.internal>
 <ad48tOVLN5Vg73jR@ip-10-97-1-34.eu-west-3.compute.internal>
 <bff1d798-2fc4-48a8-b4eb-7a550be46d07@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bff1d798-2fc4-48a8-b4eb-7a550be46d07@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/aeDIj2SBDl0EHZtb%40bdtpg>
Precedence: bulk

Hi,

On Thu, Apr 16, 2026 at 10:07:35AM +0200, Peter Eisentraut wrote:
> On 14.04.26 15:10, Bertrand Drouvot wrote:
> > Hi,
> > 
> > On Thu, Apr 09, 2026 at 11:41:39AM +0000, Bertrand Drouvot wrote:
> > > Hi,
> > > 
> > > On Wed, Apr 01, 2026 at 07:54:07AM +0200, Peter Eisentraut wrote:
> > > > 
> > > > Ok, I have committed the shown patch.
> > > 
> > > d50c86e74375 added a comment mentionning that StaticAssertStmt is deprecated, so
> > > we really need the one added in test_cplusplusext.cpp?
> > 
> > Now that 66ad764c8d5 is in, the only remaining use of StaticAssertStmt() is in
> > test_cplusplusext.cpp. What about the attached to get rid of it?
> 
> This is a test module.  Even if the construct is deprecated, we can still
> test it.

Right, but I was thinking that if we introduce a "pg_attribute_deprecated" macro
(like discussed in [1] and [2]) and make use of it for StaticAssertStmt(), then
this test module would generate Warnings.

We can still come back to it should the above be implemented.

[1]: https://postgr.es/m/CA%2BhUKGK2zuRevnNzCpVzLA7ieHnJoYPnDvgtWRcB4pVnOzchhQ%40mail.gmail.com
[2]: https://postgr.es/m/aRGa87Ab0f3ItWRV@ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com