Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 18 Apr 2026 07:54:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@postgresql.org,
	"noah@leadboat.com" <noah@leadboat.com>
Subject: Re: [PATCH] postmaster: fix stale PM_STARTUP comment
Message-ID: <aeK6Fj9TiQWCcFgN@paquier.xyz>
References: 
 <CAJTYsWVoD3V9yhhqSae1_wqcnTdpFY-hDT7dPm5005ZFsL_bpA@mail.gmail.com>
 <0f462532-9790-4334-b503-4ee522225820@iki.fi>
 <CAJTYsWVw3h1hTDyUdaDb8MmmXF0qQKzV3YkQUwC1DhvcApFvTw@mail.gmail.com>
 <CAJTYsWX=EkwTvA15=T8dE1c4iVoapTT5=nkrByd2h-18NU8hZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9/84afe9OKtbOAfX"
Content-Disposition: inline
In-Reply-To: 
 <CAJTYsWX=EkwTvA15=T8dE1c4iVoapTT5=nkrByd2h-18NU8hZA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aeK6Fj9TiQWCcFgN%40paquier.xyz>
Precedence: bulk


--9/84afe9OKtbOAfX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 17, 2026 at 07:17:18PM +0530, Ayush Tiwari wrote:
> I've attached a patch, please review and let me know your thoughts.

             /*
-             * Unexpected exit of startup process (including FATAL exit)
-             * during PM_STARTUP is treated as catastrophic. There are no
-             * other processes running yet, so we can just exit.
-             */
-            if (pmState == PM_STARTUP &&
-                StartupStatus != STARTUP_SIGNALED &&
-                !EXIT_STATUS_0(exitstatus))

The assumption that only the startup process is running while we are
in a PM_STARTUP state is wrong since 7ff23c6d277d, and this exit code
path has been missed the fact that now the checkpointer and the
bgwriter are started during recovery.  So this means a backpatch.

Removing the assertion is the right move, yes, there are other
children, so again that's an issue with 7ff23c6d277d.  I am planning
to double-check the shutdown sequence while switching to
PM_WAIT_BACKENDS under a PM_STARTUP, just note that bgworkers that use
BgWorkerStart_PostmasterStart cannot request a database connection,
meaning that PM_WAIT_BACKENDS should be pointeless, but perhaps it
makes the whole shutdown flow easier to reason about, as you are
suggesting, as making this path more complicated would lead to the
addition of more postmaster states.  Making this code simpler, not
more complicated, is always useful.
--
Michael

--9/84afe9OKtbOAfX
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmniuhYACgkQnvQgOdby
QH1rJQ//V5lkebj5A2y8qSjUIECe+HdobpYrJPo/Qk9p+OkXExw4XawzWrPQwKX1
KaD0ivy0FTussufW10NcJuzPNiFnjykqL32o7pHlcG5KM2W3ZyDXgd7zBpoeYg1d
TN/8OwO5ezbOZQnAPpe+Lb0gx5TzzQWWsR5xpN7vyoDjw1FSBgdtRWiUqRmFMNUc
1DtTGZPcG/1iwGWyiBHB5vnEapZGKI5bY+n7sZe9UKPl/GZInQ3BFy2TM/AHjjOw
RE8UJOfuxcIKxDN+/487EXx8FYWVBifI7IeluQziaBjSfQAqhZ277Xa/PbXKV3EX
7tCBF2prfYXDSeLzxz6UsBF/T0TkJa+6G2C/GUxmWltzsLjtu8rRLQuUWQMzKJBU
0M+pc7fvZfWK1cxBmu1aLecHeIRl3CbT/JSE4/5UULDhHFi19VaAw/nG05Dm8fnj
Nz1X2Rkz5bAAVypgWB2RxFhE7wi0Vfa2kQLE7XeI401XEJ0cU3nAyCcVFr9ntZo4
oxRDjZYGQSIaOl8uxEVM36/R3EGmkKcYaS4BV7rXIXP3a9n9oVd6nUTpi+KruYom
d4jCPBoRapeHkYvCi44Nb8sFbMLRL74O9xiitoE4DL6zEajvPw901P2wS4OX/9rV
lRuD7DYrjLdBJktUn0QYitbj+oX9bGbc4/xjsnSZtP44KkF8KH0=
=aJBb
-----END PGP SIGNATURE-----

--9/84afe9OKtbOAfX--