Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 18 Apr 2026 06:32:48 +0900
From: Michael Paquier <michael@paquier.xyz>
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: Antonin Houska <ah@cybertec.at>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	alvherre@kurilemu.de
Subject: Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY
Message-ID: <aeKnABrX4ShBtHkg@paquier.xyz>
References: 
 <CAHg+QDeXb9HM2VGKXQedyCp52GzajJK5KOUdNi6oLjsS0nerQw@mail.gmail.com>
 <52301.1776440752@localhost>
 <CAHg+QDf+yGGizLHAOm_q8Y9SR-tuDa4vWYp+riJ1QWnWxeeLQw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ra7t/pU9qcp6KPTg"
Content-Disposition: inline
In-Reply-To: 
 <CAHg+QDf+yGGizLHAOm_q8Y9SR-tuDa4vWYp+riJ1QWnWxeeLQw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aeKnABrX4ShBtHkg%40paquier.xyz>
Precedence: bulk


--ra7t/pU9qcp6KPTg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 17, 2026 at 10:40:39AM -0700, SATYANARAYANA NARLAPURAM wrote:
> I started with that but tried to follow the existing code pattern. This
> LGTM.
> Please add a comment as well.

Hmm.  I was reading restore_tuple(), and could it make sense to expand
a bit more the tests so as more types of varlena pointers could be
checked in this routine?  I am taking about MAIN, EXTENDED and
EXTERNAL, so as we could check more patterns with in-line
[non-]compressed, and external [non-]compressed, counting for the four
different possible patterns that could lead to repacked data.  See for
example strings.sql for such tests, that could be used as base
inspiration.
--
Michael

--ra7t/pU9qcp6KPTg
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnipwAACgkQnvQgOdby
QH2Ymg/+JtpRgQLRZJ1WRDuEpvzMBepBdZ2dmoCiFzyJCXC7OWq2O44rr4HaAmra
liOZUoQF1FAPa2wmDYisyrHzV1vGhyiyqTq6yCmaTlVcYxbqye1BWrR/DOamGITf
7jp3zBnu5gMiEwDMvPyAOXinPv5CXynkgVKLAaz6XAYz2VbMBsQ5o6XVMyAXesd5
EWJKHdXDZyO7Hy9IyifmK7geyqi1fQA5yW5nSyjICylweN2SxrV5+ZBP4nYYv+Qa
LmrLdNAd9ua+7XLaw2WSPgMgjQZJPL8+RlvrdgRSOnB/vWyaip1GLV/aAYYxZOj0
QWPYNEa/qyCOlRui7aHzTERClsZhfMKs1KpGTIW23NzkkO87+pvbWfTPg5GY7R3u
RWENqGhwJs8kzedCfZdZ49JLptbySJXxf0xpqIWS8PbiEoC0ZwaACHLKkARCX7/H
DoqCZl8u2UIdC2dnzXMGzCyoQZEkjOKjzJKzAqQGfV5iPjZ2YdvcXEnB9KBX+aAS
DugH3W5xIjqCih5Nb1IlAiL+uyMnQvMfdTO6PS5RbTQh40GidpaDNk7rKEQmJX+A
tdx5k2oLBmnF0rwcnK5fx0theYMNfkHjgNhKRw9MZ1EcLFtKMK+Pn2aXsMEVS4jc
u7/cCffgwuLLvuxbeKqw2y06NbLZWA2qxA4xnb71H8UcomwvPt4=
=fBwF
-----END PGP SIGNATURE-----

--ra7t/pU9qcp6KPTg--