Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDqr3-003Qdm-14 for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Apr 2026 21:36:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wDqr1-00BEZA-20 for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Apr 2026 21:35:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDqr1-00BEZ2-14 for pgsql-hackers@lists.postgresql.org; Fri, 17 Apr 2026 21:35:59 +0000 Received: from fhigh-a5-smtp.messagingengine.com ([103.168.172.156]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wDqqz-00000001X20-0zel for pgsql-hackers@lists.postgresql.org; Fri, 17 Apr 2026 21:35:58 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 062401400156; Fri, 17 Apr 2026 17:35:57 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Fri, 17 Apr 2026 17:35:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1776461757; x=1776548157; bh=LdZPEpjg8w 2/M+ACFrwi6OsyQ31V0ocB+F6LZPqKk98=; b=oCxa3yA187VciPT3UPp3lNlze5 JNalfkPzPjzd7PVz3N4zLYxO/vbEuP48VV7ujI2qf1GsRAstEhc3l3E6nM2Nf01I +ZwqEXoc8LQJEa0RI8OLM5E0z6BoZETWsUUWWayScUMd4KxsBvfBzx1sYrl3ugPn rshgSlhtCxAUb61iL1SA+H6K4jLcCncOl9QhMBnC/6RUk7RYv6qpZCEwHyP8Q2ft VZXD/l6gdIx6DwN5KvsTe8txsC4Fh2xtH5wXjp1d996WEpbWPzafyfNYZGLZ4j// GjiXSLMHJg6OeQ4LmgGLs7dKqbbVvHr177kWzgy6XRvNEjJTOvW5CahdwGfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1776461757; x=1776548157; bh=LdZPEpjg8w2/M+ACFrwi6OsyQ31V0ocB+F6 LZPqKk98=; b=vlWIsT4OG/PMWvduzsHhdl6E9ly/iZkRiXmcfZi//PFges0wzWN bxoZkOWCAgworU00j6Qdxm1z4IGqL69DcgWUMipn0augwfydIat6JvBYtQKy3zBX ve1lQldKf4VZFa4E/EU3ZKuExgkdIlzOf4w+POFaTl3CYK6oJzd4ZLtaecS8wLlX 8objOjrgjjLBYoERTrB4qo5p4qId0ugEY8gjrG34M86LSAL1rFM1rsWH4/dgcRm0 ov8CGr5wLQhId8oMlZw+dsdcONWCSlZ82W0b1QKh2RmGwUFNC/3WxEX9uVEnOjxZ S7kIzKbhAi3H+vZrZr3+4Dh0mMpM3js6Hyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdehtdelkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecufghrlhcuvffnffculdefhedmnecujfgurhepfffhvfevuf fkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgv rhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpe egffejvefgveduvdejtddvtdeijeehudeuledvudeftdfgfeejvdekveekiedvvdenucff ohhmrghinhepphhoshhtghhrvghsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih iidpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheptg hhrghrshihrghmsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghk vghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Apr 2026 17:35:56 -0400 (EDT) Date: Sat, 18 Apr 2026 06:35:54 +0900 From: Michael Paquier To: DaeMyung Kang Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Use direct hash lookup in logicalrep_partmap_invalidate_cb() Message-ID: References: <20260417174450.4158878-1-charsyam@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="USMBnBk2vKPJYWpc" Content-Disposition: inline In-Reply-To: <20260417174450.4158878-1-charsyam@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --USMBnBk2vKPJYWpc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Apr 18, 2026 at 02:44:50AM +0900, DaeMyung Kang wrote: > LogicalRepPartMap is keyed by the partition's OID, which is assigned > to entry->relmapentry.localreloid when the entry is populated in > logicalrep_partition_open(). The invalidation callback therefore > does not need to iterate over every entry to find the one matching > the invalidated relation OID; a single hash_search(HASH_FIND) on > reloid suffices. At this stage of the release cycle (aka feature freeze is in effect as of v19), I'd recommend that you add this patch to the next commit fest, so as this could be considered for v20, whose development should begin next July. See [1]. [1]: https://commitfest.postgresql.org/59/ -- Michael --USMBnBk2vKPJYWpc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnip7oACgkQnvQgOdby QH1QSw/+LFet7RkWZySt03OKU+b1+DDJKmN6Pb+rLBFOwyjVO8hksW40rZJaqgaO mSri7SyScC58RLfclXI23DqOpe2i5g/TFb3XfTFA8yq8lpQsl6KoAvv4cMwstlaj PU3diwVJnd/h5pfElMCj9/Xvsi8x/L0zphPyrIoRI+64+QWWF+bgKgnNWFR1Eu1c N67e4+NKvCLhc9DJ7E4yAln/OdzlYhrsgCvQLisQs1u1g7ZJfWwzaewz4ghWNIyb WFHr++ESyDTfvgstt3iozBJ9/HUUN22iKRIbYUPov5VSfAMIhWMGgeD+p7+VgF2j y41pi1QnAXwux2IutTnLP8YyuBsgJMBZhFRv81X8fmTVkt1NZBGO3DE4lTVqbha7 joc+APlNDNspg9IV3P5mXXJbFi/6No0Oav+i7CnTIaZ4EVgRf5qXmV0y+Cu1WY3Y 5TE/EyfKfryKZKzoaGnDNnTm5UAr4BQNNP2uT22T9vjCKOdFtGustVDYzWlxO7cu rHNBfbYc4gV6iEGZJfckhpxEbLl0/XeG3q/0c+o1deVjD1UKmsUFilmp6ciueBuO YHP5Ev5LQ67ft8iED6lNvnRQj2UksqwzZREy1zE41GDZmqPYb4nB7gzHiEsF9vZi FTRJv4VL/kJeHEpHqn5g/dsw9d53OJISMP6667xlDj6XtaftCvI= =/s/L -----END PGP SIGNATURE----- --USMBnBk2vKPJYWpc--