Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 18 Apr 2026 06:47:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Xuneng Zhou <xunengzhou@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
	Alexander Korotkov <aekorotkov@gmail.com>
Subject: Re: test: avoid redundant standby catchup in 049_wait_for_lsn
Message-ID: <aeKqac6dHfCNoNxb@paquier.xyz>
References: 
 <CABPTF7WZ1yuYz8V=xsbghg8e7qaAm5MpyNw6BthWcbN7+P6biw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="iyuxag5KhNENjmbE"
Content-Disposition: inline
In-Reply-To: 
 <CABPTF7WZ1yuYz8V=xsbghg8e7qaAm5MpyNw6BthWcbN7+P6biw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aeKqac6dHfCNoNxb%40paquier.xyz>
Precedence: bulk


--iyuxag5KhNENjmbE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 17, 2026 at 08:25:35PM +0800, Xuneng Zhou wrote:
> The change preserves the same coverage while removing one redundant
> replay catch-up on the delayed standby. It appears to reduce the test
> runtime by about 7 seconds, though I have looked into why much of the
> improvement comes from this change alone.

Alexander may think differently and remove that, but I disagree.  The
test is clearly written so as we want two wait checks to happen, for
for CREATE FUNCTION, and one for CREATE PROCEDURE.  Removing the first
check to keep only the second one removes its meaning.  In short, I
see nothing wrong to deal with here.
--
Michael

--iyuxag5KhNENjmbE
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmniqmkACgkQnvQgOdby
QH24vQ/9GBVn2fO/rWDGddgNCRuUYP6zQHDDTtrG/cExliKfTUwuLgbrjF9nOtCG
tBUFXY+w0LAQ4tAcEEVUR8lNfjFNdQ2eO2GlUwXzzJ7jG1mdsRMGhBdEteFvkR/d
459K9ihm9Yl3q4I6EIyaadvSpK5lUuVnROl/PruXmPo8kpehOmvIGZ7fbp3cnz19
eCziyes/JQHtTONuj4rzAHJFII0wldqLKVqLG04Ibf2QKEbPVnRM3f4RjC4DfTy8
8XcpEqUV89KGuvM5Uas4gqmW/bmArCfVcgaKKx5E8Hi6RWbvDmjhswTZ34AKE82Y
umnKp6zxepVgNEFwFiUJwpTVCV1znztszPzaoYx27M9hB/R4tyIltJg3QRo0FhaX
zjMME6VuNXklGnH5/wl8rs6BalWzorMPG/f2mlO824PwpMQTTkF9EifNJxyHn5ME
Wo4nhFjRZ0A9/caKjo3k1PfM4dSOEU8gyovK/zLP4ok0LhOlajxmWJC56gHvtq2o
7xJpoJODzyGXM8QQrS/u9Gv+TmMdirHpLY9HDlgSe+f0jKeQcBMS4kN6BE11i8dj
hoj9nnAvSDm4JT9DlgYaB+qzSNh/Y9zSmNNasRxedeK/RF3qHECVIMv92cQglTLM
QGblwGkm65N8hocLgmxlK3bgwgMs1DpSe2Gy63dLhMTpaJI3nl0=
=ZCKo
-----END PGP SIGNATURE-----

--iyuxag5KhNENjmbE--