Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 20 Apr 2026 07:07:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Haibo Yan <tristan.yim@gmail.com>, Mohamed ALi <moali.pg@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Fix: Partitioned parent index remains invalid after
 child indexes are repaired
Message-ID: <aeVSPx7F3ghkZugb@paquier.xyz>
References: 
 <CAGnOmWqi1D9ycBgUeOGf6mOCd2Dcf=6sKhbf4sHLs5xAcKVCMQ@mail.gmail.com>
 <CABXr29GbJe7-vbm0Fn=HWx3vQonwFtv_zO1pSc5FZAvjLuUDVA@mail.gmail.com>
 <CABXr29Epj=23eYAWg_mTdiXYQQzJSVN22uk6tK8ei0ts5wXvSQ@mail.gmail.com>
 <CAA5RZ0s16eHrzcDupipAxC++e-p_n_M7Fpg-MG-V59fB=wykLw@mail.gmail.com>
 <ad1rubGPdHxNnDh5@paquier.xyz>
 <ad5l0sGiJwdkXI-L@paquier.xyz>
 <CAA5RZ0uM7_YPdSahGh1sGeewMb9SzKswyLaZty8aR+a7XpQydQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ubv8NtJQshoHDym8"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0uM7_YPdSahGh1sGeewMb9SzKswyLaZty8aR+a7XpQydQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aeVSPx7F3ghkZugb%40paquier.xyz>
Precedence: bulk


--ubv8NtJQshoHDym8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 18, 2026 at 09:37:48AM -0500, Sami Imseih wrote:
> Here is the patch with tests. It adds a test for this case using
> multi-level partitions and ensures that the parent indexes are
> validated once a child index is set to valid. Also, I added the
> negative case where only one child index is validated to ensure
> that the parent indexes remain invalid.

That looks sensible here, including the test coverage.  Thanks for the
patch!

One thing that I'm tempted to add is more scans to check indisvalid
across these commands, particularly after the individual ATTACH
PARTITION bits on each individual index.

A second thing.  Do you think that it would be worth adding a
partitioned table that has no leaves in some portion of the test?  I
was thinking about a partitioned table called idxpart2 attached to
idxpart in the first part of the test.  I've found this pattern=20
usually useful for this area of the code when recursing with
validatePartitionedIndex() from a parent.  I was also thinking about
a partitioned table idxpart3 in the last test block, but as you want
to check that indisvalid is not flipped to true for the parent if a
child is !indisvalid, it would not be adapted.
--
Michael

--ubv8NtJQshoHDym8
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnlUj8ACgkQnvQgOdby
QH04CQ/8CwKxFc0y5f1VdhkX1EYjCh1YBMJyDrqZ5SP7h+U1MQuKNqyzggHCyd8W
CdSVOozVeh89we54jqmMirktih7NlUe9jkaetuaut9/Sv9OawwDB1Mxz4fiVqlT1
BrrVWVjOpP3QPgwbj99r3kYD3qZUs09V6O9+UQDtM+cdUu/LPtE4K7N1CImlOhmL
pFZcBierfD+KoG/S8oSvVqwXUewzx4x7L3SBBFOuaSJ8oXcDfLpiH8Vgs3Qij/yc
nLNiRCfobwMYvFzxf+ZFH3pTRnoKDv6gKzmj0nDiDg+5N0lgpRT0DeLTZOh9oWZ4
NbhkdzDdU4gl2wPnan20/Fq1zmrDV/C8u3uyzrL6o8XczoC1DJ/PNFio/8PEEVzw
Pbq0gKzDhEZ+fiBGs19WTe0lK9CVtKW6zuAhQZTIB/0kMsNwP79Npo71xrir1BDX
w0dgvOaXoJ6BIntIWTj+ydzyeT2IISUF8G7NuimtTghzfDA7SoBlvDHR2+PKRe91
NkpABsnhFH0XpcsLzSM0gfqywjlwmd15UYJ5w0TyiuTlM9Jb8EikpmUZ+uWNFfxT
LquJwFtQM83EcR1CWBx0fx2EZmgTNBlXHK9HCPyx+2fU4ms0qu16xBvfmBPSeAmD
NPkGqoOn8mBj8NH5Ns3KSivwjlp2Mo5ZMZxUfN57YFjLInvaCeA=
=M/Hd
-----END PGP SIGNATURE-----

--ubv8NtJQshoHDym8--