Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wEaTc-004Aye-2b for pgsql-hackers@arkaria.postgresql.org; Sun, 19 Apr 2026 22:18:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wEaTb-00Ghuu-06 for pgsql-hackers@arkaria.postgresql.org; Sun, 19 Apr 2026 22:18:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wEaTa-00Ghum-2N for pgsql-hackers@lists.postgresql.org; Sun, 19 Apr 2026 22:18:50 +0000 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wEaTY-000000022DE-2LmJ for pgsql-hackers@postgresql.org; Sun, 19 Apr 2026 22:18:50 +0000 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id 28D617A013F; Sun, 19 Apr 2026 18:18:46 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sun, 19 Apr 2026 18:18:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1776637125; x=1776723525; bh=01Je5j/seJ 14/5daDKjf4Fj5yIYsjZ0fSq9pTP9LzrA=; b=WJ2pVZkuUwe3ur4Yv67f3QLNXm U5eEUAUIeRLbMRNZ9+837bj7/w9q4gAkBnWlHwN3Yu1l2XC/Wg1OIl3XJIsVLo1l iZ5RJ0NatUpKa4zLWiv9Z8ZCv2OAcNQveUHHuz+dTG0xHmZuby+9rd40PO0aVZkN E1Cmw2hH4CnA1BEw4l+B88MI8I9fZzNetnt00KqEzcsjfa/twfqfVPgEU+TRRcwR oQ4LgQf7euciTLHQtsfGoNxOyziwFlPouNnX5JZNVH9+5QwSxTXC5hTmls6mlzY3 BcgkxOakwI5WzGG8kCacprxFOWyCeTFuR8A27WS3g8IQQaDNyk4wskpSQcrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1776637125; x=1776723525; bh=01Je5j/seJ14/5daDKjf4Fj5yIYsjZ0fSq9 pTP9LzrA=; b=jim2xnV3mtPZZo0mUVXsL1fgs7Oh7eTuJNQWUpUREsjYUtUGWP8 sgMTROJA37kbVmYBgy2yZw3R5GRqJO8Crb4VHA/uo3kSGkJRA4nX0N2cKUpfuccB WVc91Wggzul5SPfpDsxKcbwHZMp07yOgJXmou03XIU9MsibmC63j7T70G2duBQYO rwkfANkRpMe4KcMLHVXys3qACEs3gaQ0pHHBODQGSDPQOaQ0hac93FS6iYPWNSiG b/jt3SQohwNgqUAmbOxYIEwPf8p5bGN/0HYyrscOfz5hNXSjpaDF6Wl10FY1rryH MeCHoJ3NcD9kot7XdCoD4yBykDJrpu2lGPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdehieekfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehtghhlse hsshhsrdhpghhhrdhprgdruhhspdhrtghpthhtohepphgvthgvrhesvghishgvnhhtrhgr uhhtrdhorhhgpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrshesphhoshhtghhrvg hsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Apr 2026 18:18:42 -0400 (EDT) Date: Mon, 20 Apr 2026 07:18:37 +0900 From: Michael Paquier To: Tom Lane Cc: Peter Eisentraut , pgsql-hackers Subject: Re: some extra warnings from MSVC Message-ID: References: <1142ad86-e475-41b3-aeee-c6ad913064fa@eisentraut.org> <419716.1775916598@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DDlmBHsJb3oCVCEY" Content-Disposition: inline In-Reply-To: <419716.1775916598@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --DDlmBHsJb3oCVCEY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Apr 11, 2026 at 10:09:58AM -0400, Tom Lane wrote: > I think it'd be a good idea to warn even if we can't make gcc do that. > I think Windows is the only 64-bit platform we deal with where long > is just 32 bits, so covering the case in MSVC will expose bugs we > would not notice otherwise. Interesting issue. I did not notice this thread until 9018c7d37bb4. Please do not hesitate to add me in CC in the future, as 13b935cd521 has my fingerprints. Thanks for fixing the issue. -- Michael --DDlmBHsJb3oCVCEY Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnlVL0ACgkQnvQgOdby QH3IHA//WFfFbZ75r1PdqHW8Bqc3lWnwYkUKSqmp5rVuFA/9n6rs+RrahV7lqady hCZAT1UT5DFLs809nF2eMtlTQFnjz1hG6/Q49GU1y6Ion9CTzUE3VLJvEQ1jeMV5 U2X1yCjiATadx08T082o+5Snm42mPXt6rID6wSX1thS6846CaBg/AxVXpYDHYgMg RHqxk9CQm6mexKoIiK/mYa1A9tqfIVfbHzW/SD1UQCzvBd6B747LRtC6Ru95EUl1 8Q6AYbOBXd4U8QECiLfTlHLZvl4EewUcwpqYCe3OkmIc/gItRycqIncMx/Udxc+b b/VKXUaU6RvGkQL7btHynovCe/e2PB8vd7ag0SgjQ8lXMRO3R7ai9TWQ50KzZ+sC BAmLuLvYret9b1QwJuCYCFiE0SAf+mA/uFFN9yS0rcQA8JRaoxj24dj7dGYOgkLT 3jRxJZQaYjYDn4+f5R80erw5vhny+NN4n9abpINRF03hCD9SzHwdQHG3Sfg8Jtfw WvIo8idhTuAuusEH14ErDuKrsar5VNrSirdvnjlrY9w16ZBmLJIy2GiCH/2Ru/86 kVZd++/r2PBxnS3vH0bECWEB9ClpCtbopVSJlihyPjYaj9m5wXg3w967wALxb2Fa O1I6xJ2dmeaWY6btKCcsNopoi8iQm5vjTIRWhjazPyi5MH69gfI= =Agqo -----END PGP SIGNATURE----- --DDlmBHsJb3oCVCEY--