public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Tom Lane <[email protected]>
Cc: Antonin Houska <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Mihail Nikalayeu <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Srinath Reddy Sadipiralla <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: [email protected]
Cc: Robert Treat <[email protected]>
Subject: Re: Adding REPACK [concurrently]
Date: Mon, 20 Apr 2026 18:30:25 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2026-Apr-20, Alvaro Herrera wrote:

> On 2026-Apr-20, Tom Lane wrote:

> > I think you need to move these tests out into some other test suite
> > (or make a new one).
> 
> I'll see what I can find.

I think the simplest would be to add them to
src/test/modules/injection_points.  We already have some repack tests
there (because they needed injection points), and it has an SQL suite,
so we would not be adding any extra overhead.  However, the new tests
are not related to injection points, so they would be out of place.

Another possibility could be src/test/subscription, but it doesn't have
sql tests; doesn't seem good to have them just for this.

There's also contrib/test_decoding.  It's somewhat vaguely adjacent, and
the tests aren't _really_ about the decoding part, but of all these
options, it seems the least bad one.

I don't like the idea of adding another suite.  Too much scaffolding for
so little, I think.

I don't have any other ideas ATM.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"We're here to devour each other alive"            (Hobbes)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Adding REPACK [concurrently]
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox