Date: Mon, 27 Apr 2026 15:03:37 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	Zhang Mingli <zmlpostgres@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	johncnaylorls@gmail.com
Subject: Re: [BUG?] macOS (Intel) build =?utf-8?Q?w?=
 =?utf-8?Q?arnings=3A_=22ranlib=3A_file_?= =?utf-8?B?4oCm?= has no symbols"
 for aarch64 objects
Message-ID: <ae_BGTKwkAXQRY7R@nathan>
References: <229aaaf3-f529-44ed-8e50-00cb6909af21@Spark>
 <4df5af1a-8528-4f9f-9daf-ec069bd66f69@eisentraut.org>
 <1453046.1770218933@sss.pgh.pa.us>
 <aYN5vmHb89m3sfgs@nathan>
 <1472307.1770229663@sss.pgh.pa.us>
 <aYOTFLqyvvPUQLN8@nathan>
 <ae7BvFTamKBDF1ga@nathan>
 <2446899.1777256313@sss.pgh.pa.us>
 <ae7KiQcfDaavu5cD@nathan>
 <ae-8WBrqoTWYCTCG@nathan>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="Kv0/eRuy+QUPVP2u"
Content-Disposition: inline
In-Reply-To: <ae-8WBrqoTWYCTCG@nathan>
Archived-At: <https://www.postgresql.org/message-id/ae_BGTKwkAXQRY7R%40nathan>
Precedence: bulk


--Kv0/eRuy+QUPVP2u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 27, 2026 at 02:43:20PM -0500, Nathan Bossart wrote:
> On Sun, Apr 26, 2026 at 09:31:37PM -0500, Nathan Bossart wrote:
>> On Sun, Apr 26, 2026 at 10:18:33PM -0400, Tom Lane wrote:
>>> I previously suggested that we should teach the build systems not
>>> to build the foo_x86 and foo_aarch64 modules when not on those
>>> architectures.  That was shot down for reasons that made no great
>>> amount of sense to me, but I think it'd be fairly easy and clean.
>> 
>> Yeah, AFAICT that's our best bet.  Will write it up in the morning.
> 
> Here's what I have so far.  Two notes:
> 
> * Since pg_popcount_aarch64.c only builds symbols when USE_NEON is defined,
> I needed to teach the build code about that #define.  So, this patch
> effectively moves USE_NEON and USE_SSE2 from c.h to pg_config.h, which
> happens to be the first #include within c.h.  The reason that I bring this
> up is because back-patching it seems a little scary, although I don't see
> any concrete reasons it would be unsafe.
> 
> * pg_cpu_x86.c has a similar problem, which I haven't fixed yet.
> Presumably a similar approach will work there.  I've added John Naylor to
> this thread for his thoughts.

Sorry, I noticed I was using USE_SSE2 for choosing whether to build
pg_popcount_x86.c, but the code in that file is actually surrounded by
HAVE_X86_64_POPCNTQ.  New patch attached.

-- 
nathan

--Kv0/eRuy+QUPVP2u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v2-0001-avoid-ranlib-warnings-on-macOS.patch