Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 28 Apr 2026 08:26:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Kirill Reshke <reshkekirill@gmail.com>,
	li carol <carol.li2025@outlook.com>,
	Roman Khapov <rkhapov@yandex-team.ru>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	zengman <zengman@halodbtech.com>
Subject: Re: Use correct macro for accessing offset numbers.
Message-ID: <ae_wtOexQA6OlY3D@paquier.xyz>
References: 
 <CALdSSPidtC7j3MwhkqRj0K2hyp36ztnnjSt6qzGxQtiePR1dzw@mail.gmail.com>
 <F722FCB5-7790-4043-8F64-8D9676943726@yandex-team.ru>
 <CALdSSPgzLF8Vx7S0HpJo4rR3tc6Wqnr68JZ9LMOoVGPZSM0dTA@mail.gmail.com>
 <aWQw5ok9a3x5Pwhx@paquier.xyz>
 <TYSPR01MB6650128F7CCEBE1C809AE51E8181A@TYSPR01MB6650.apcprd01.prod.exchangelabs.com>
 <CALdSSPgVwxxT5_kXpQktmiYfir=gPuYzaiiEpJadqN91VshHHA@mail.gmail.com>
 <aWdO6BNkEH9ZStof@paquier.xyz>
 <97f9375a-be61-4272-a44d-408337fe8fa6@eisentraut.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FqBa53848fFLq4kV"
Content-Disposition: inline
In-Reply-To: <97f9375a-be61-4272-a44d-408337fe8fa6@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ae_wtOexQA6OlY3D%40paquier.xyz>
Precedence: bulk


--FqBa53848fFLq4kV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 24, 2026 at 10:23:23AM +0200, Peter Eisentraut wrote:
> The thread [0] is proposing a patch to change these things in the opposite
> direction, effectively reverting commit 6dcfac9696c.

Thanks for the poke.  This qualifies as an open item assigned to me, I
guess.  I'll double-check the whole and reply on the other thread
where the patch has been posted at [1].

> The real problem here is that offset values that are uint32 are being output
> via the SQL type smallint, which can't handle the whole set of values, but
> this is probably not a problem in practice.

Will check all that.

[1]: https://www.postgresql.org/message-id/CAJ7c6TMcGu8qmRe1gZfJ-gOzVnZq-t%3Dfwn-UuyStx1w6ZyydMw%40mail.gmail.com
--
Michael

--FqBa53848fFLq4kV
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnv8LQACgkQnvQgOdby
QH1Gpg/9GZc+Lh4/eEbw/nuNzILBGLokGoBSoPi5z7wbW4bs8d/XNrWgUpBEf5o1
E6PIqOLSOOfB/DLB/GiWMsTDuBcQTUksjpORLWmPJDZVqrCLM5SOjtR3YEmvT2Zr
pYr6E6S0EtjGbZvjvNf59x8SJ1AQU6uLLgnvnmDlQtUyhgdCFBKeBhTOab8m3jdH
wMR2xxIxBoXRCAbveAOoMWDylBObSHpaAPsThxfrMH/DWOmcXSf0fm7+61Y8QiwU
P0BKvm4ZLLAi1dx3DHMtfLgGweiIAs0hCQN+gaM+6nx3RScSX2CS5mvSYw5TunOL
2ajhDBJy2ap8seXiAqH5HWuANV0iaHhZzyMx7TCtD1izRyLITEu1pPbZHodf2uZl
OHOMlKMqIU5HdhHPCTPSyIiseO7S87209n6e7JaSW/yvF8jDhJgQsLfnspJHCejL
97Scchzsz+gl+k4EtcRLDpIGJUy8UyCWuWNodqkOSsfpPyXwMa7HEjeXW2FCUo7b
YO3gGaZDE04dMmbEzAQ2bAAC9VjKpq4vjwLivQxc/kgmV3L17Gm1iOliFhHtezzW
2qnG/vjdFCEok4hKShJRJ4Z9ZltbcrN9GBk0C+M3tTG5O/9Tt1GIeYhu++KNDEXB
dlBggBtQh7u0urgwsfbOKMwV3DiE9rLq/kzPU1ij/ijNf4KvIzA=
=ktEy
-----END PGP SIGNATURE-----

--FqBa53848fFLq4kV--