Message-ID: <aea499f7-06cc-43fe-9a89-58402bf12d52@pgmasters.net>
Date: Sun, 5 Nov 2023 13:30:07 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add recovery to pg_control and remove backup_label
Content-Language: en-US
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
References: <2daf8adc-8db7-4204-a7f2-a7e94e2bfa4b@pgmasters.net>
 <CAKFQuwYPu+PMyNvwnvs0x_7c9X57igMj1ED-kdYhnF+GEZvqJg@mail.gmail.com>
 <2e7c913d-3c60-411a-b7d9-2d728b903286@pgmasters.net>
 <CAKFQuwbn3rvA7o-=Sbn93mo9MJPDmExBWYa5Lph51hyZWtj13w@mail.gmail.com>
From: David Steele <david@pgmasters.net>
In-Reply-To: 
 <CAKFQuwbn3rvA7o-=Sbn93mo9MJPDmExBWYa5Lph51hyZWtj13w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/aea499f7-06cc-43fe-9a89-58402bf12d52%40pgmasters.net>
Precedence: bulk

On 10/27/23 13:45, David G. Johnston wrote:
> 
> Let me modify that to make it a bit more clear, I actually wouldn't care 
> if pg_backup_end outputs an entire binary pg_control file as part of the 
> SQL resultset.
> 
> My proposal would be to, in addition, place in the temporary directory 
> on the server, Postgres-written versions of pg_control and 
> tablespace_map as part of the pg_backup_end processing.  The client 
> software would then have a choice.  Write the contents of the SQL 
> resultset to newly created binary mode files in the destination, or, 
> copy the server-written files from the temporary directory to the 
> destination.
> 
> That said, I'm starting to dislike that idea myself.  It only really 
> makes sense if the files could be placed in the data directory but that 
> isn't doable given concurrent backups and not wanting to place the 
> source server into an inconsistent state.

Pretty much the conclusion I have come to myself over the years.

Regards,
-David