Message-ID: <aeaa12f2-830c-4606-ab46-215911498580@gmail.com>
Date: Mon, 25 Nov 2024 14:21:11 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
To: Alexander Korotkov <aekorotkov@gmail.com>,
 Richard Guo <guofenglinux@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Robert Haas
 <robertmhaas@gmail.com>, Nikolay Shaplov <dhyan@nataraj.su>,
 pgsql-hackers@lists.postgresql.org, pgsql-hackers@postgresql.org,
 Peter Geoghegan <pg@bowt.ie>, Marcos Pegoraro <marcos@f10.com.br>,
 teodor@sigaev.ru, Peter Eisentraut <peter@eisentraut.org>,
 Ranier Vilela <ranier.vf@gmail.com>,
 Alena Rybakina <a.rybakina@postgrespro.ru>
References: <567ED6CA.2040504@sigaev.ru>
 <CA+TgmoZ3tQ3Zwzo+9uXQL_tf0rDHQHKeZ4bGt1LDvL+_dqghUg@mail.gmail.com>
 <CAPpHfdt8kowRDUkmOnO7_WJJQ1uk+O379JiZCk_9_Pt5AQ4+0w@mail.gmail.com>
 <CAPpHfdu9QJ=Gbua3CUUH2KKG_8urakJTen4JD47PGh9wWP=QxQ@mail.gmail.com>
 <CAPpHfds3m=55cY1ea1TRzUAgD3pgwmvqm=exVMdOM4q+YT6kHg@mail.gmail.com>
 <45050ba9-3777-4cc1-89ad-a02deebe7729@gmail.com>
 <CAPpHfdvxF1OZUoJr2bg8cmAnty-KyRkswPa3hCPSmR5gSx7-Yg@mail.gmail.com>
 <CACJufxGS_MKqkfnw3BMhfi+=xuf2SAFvwf0Eq3e12XqAQaKdZg@mail.gmail.com>
 <0026f562-d403-4f97-b9dc-3fe3a279e8c9@postgrespro.ru>
 <CAPpHfduzBgV3AecMU0jFqOSjK9iP86HiHEzj2Hv6hLqWu7JJFQ@mail.gmail.com>
 <CAPpHfduqOuvh6i=jYDPWnAUg325hsOLUAW9r_awdirQRA7uzHA@mail.gmail.com>
 <37bf870a-22e0-4aba-b845-549482118f8d@gmail.com>
 <CAPpHfdtPkA3XGM+FOanXfFNm45YEMkuqpfL0ZSL7uOP1bHPPEg@mail.gmail.com>
 <CAMbWs4-siKJdtWhcbqk4Y-xG12do2Ckm1qw672GNsSnDqL9FQg@mail.gmail.com>
 <CAPpHfduPWu6auMbR3SqmcJs0Ju459PHgy96MySUSxVScUJMxBA@mail.gmail.com>
Content-Language: en-AU
From: Andrei Lepikhov <lepihov@gmail.com>
In-Reply-To: <CAPpHfduPWu6auMbR3SqmcJs0Ju459PHgy96MySUSxVScUJMxBA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/aeaa12f2-830c-4606-ab46-215911498580%40gmail.com>
Precedence: bulk

On 11/25/24 14:08, Alexander Korotkov wrote:
> Hi, Richard!
> 
> On Mon, Nov 25, 2024 at 8:28 AM Richard Guo <guofenglinux@gmail.com> wrote:
>> On Thu, Nov 21, 2024 at 3:34 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
>>> I'm going to push this if no objections.
>>
>> Here is an Assert failure in match_orclause_to_indexcol.
>>
>> create table t (a int);
>> create index on t (a);
>>
>> # explain select * from t where a <= 0 or a <= 1;
>> server closed the connection unexpectedly
>>
>> The assertion is that the collected Const values cannot be NULL and
>> cannot be zero.  The latter part about zero values doesn't make sense
>> to me.  Why can't the values be zero?
I guess, this code came from the first raw prototypes designed with the 
erroneous assumption that they would check a NULL pointer.
Anyway, thanks for looking into it!

>>
>>      Assert(!value->constisnull && value->constvalue);
> 
> Yes, this is a dumb assertion.  Removed.
Thank you!

-- 
regards, Andrei Lepikhov