Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 21 Apr 2026 10:00:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@postgresql.org,
	"noah@leadboat.com" <noah@leadboat.com>
Subject: Re: [PATCH] postmaster: fix stale PM_STARTUP comment
Message-ID: <aebMIJakOD_XEj69@paquier.xyz>
References: 
 <CAJTYsWVoD3V9yhhqSae1_wqcnTdpFY-hDT7dPm5005ZFsL_bpA@mail.gmail.com>
 <0f462532-9790-4334-b503-4ee522225820@iki.fi>
 <CAJTYsWVw3h1hTDyUdaDb8MmmXF0qQKzV3YkQUwC1DhvcApFvTw@mail.gmail.com>
 <CAJTYsWX=EkwTvA15=T8dE1c4iVoapTT5=nkrByd2h-18NU8hZA@mail.gmail.com>
 <aeK6Fj9TiQWCcFgN@paquier.xyz>
 <CAJTYsWUEm1h_k+4Wwnri+n+V8MGPSAeyU27ehH+YwiFjJwYRvA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PUeNO152+YElxQt0"
Content-Disposition: inline
In-Reply-To: 
 <CAJTYsWUEm1h_k+4Wwnri+n+V8MGPSAeyU27ehH+YwiFjJwYRvA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aebMIJakOD_XEj69%40paquier.xyz>
Precedence: bulk


--PUeNO152+YElxQt0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 20, 2026 at 12:11:45PM +0530, Ayush Tiwari wrote:
> Agreed, this is latent since 7ff23c6d277d (v15). I can prepare a
> back-branch versions patch for v15..master once the master patch
> shape is settled.

No need to.  I have poked at this problem a bit more, stracing my way
as you did, and after more testing across v15~HEAD, I have applied it.
For v15, a difference becomes necessary at HandleChildCrash(), or we
would begin to fail the shutdown sequence should the startup process
have the idea to PANIC.  This maps with the changes in v18 and HEAD
where this has been replaced by a switch/case.

Another thing that I have spent a long time looking at is
process_pm_child_exit() and the interference that this could generate
for the startup process case, but here as well I did not spot any
issue, so I think that we are in the clear.

There was also a comment at the top of postmaster.c that incorrectly
claimed that the checkpointer and the background writer were only
started after switch to PM_RECOVERY, which was wrong.  I have tweaked
that while on it.

That was a good catch overall.
--
Michael

--PUeNO152+YElxQt0
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnmzCAACgkQnvQgOdby
QH1Z3A//SDHqx1HzaXZpbGjYv0kjJ4eOJiQuU0TG5bgCwQU9hc9Jg26StbtkON+I
Y7Ejt7sjkLj03bL3WdzCU4iV0li4sipA1g8fqW4ih0WVjHM9m5TbXEEa64L6fMYS
9Tr8cyOFxlOAR7oj1g+hPsuzDSUKW7DFcpk/PWeDCDirEihy00i9bJVAjt+gjplN
frVI61Mk+7DMtoBLRbL/4MMVUIpdQTviabL5BlfIZ2qCoZOqfsKzVoXefQY0a31A
ZcJUUfMREAGKwkqUA48upmJ/+4vzsnSefJeUEAZmUbizZwITCkERdHtZxXIJyjFY
Iv7wwboO35NtiZqHS7YqYAbrNwQYhL7PTaSxiZdoyaT3iyEtQqwGye9C6ItqFUS4
Ru4n0ruPLXPn4bElj+T9DuIJFsxsoTr/E+1bn9NekJ8DM0ugRKof47CDL0mprFn3
LVgEdWDJ+sC1MzrLQEThF4cYtrvnA3wjhj1QLb1JLaRsQCM2/V5xf6RatH7Hs/0d
gn0xdPysJKdZtUgSeGW1N19o9CS+zxkyQMKFi+IdnomOK9HOdt+57m+5rtwOais4
WDyKsXgpWruQkjXVBljXMFIgU1Gi5qGusc9OLYPQgXpJMr6sO8RNAGf2eXHQ46iw
XdVlfo6ZzxNcEnZT9TbJ7DGHWrlGX5XC5Qv/dDdiHV8MbPfUdYc=
=jdG9
-----END PGP SIGNATURE-----

--PUeNO152+YElxQt0--