Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 21 Apr 2026 14:43:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tristan Partin <tristan@partin.io>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add editorconfig support for Postgres spec files
Message-ID: <aecOai_V8w5swNhG@paquier.xyz>
References: <DHUWT364KEGW.2YFYVOL3A2FTV@partin.io>
 <29230792-69b4-473c-b2a7-7801bc8769e0@iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="v87X9NtEWwuOSa/1"
Content-Disposition: inline
In-Reply-To: <29230792-69b4-473c-b2a7-7801bc8769e0@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/aecOai_V8w5swNhG%40paquier.xyz>
Precedence: bulk


--v87X9NtEWwuOSa/1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 17, 2026 at 11:18:22AM +0300, Heikki Linnakangas wrote:
> src/test/isolation/specs/nowait.spec: indented with 2 spaces. But there a=
re
> some tabs too.
>=20
> src/test/modules/injection_points/specs/repack_toast.spec: Tabs
>=20
> src/test/modules/brin/specs/summarization-and-inprogress-insertion.spec: =
Mix
> of tabs and spaces, width 4.
>=20
> Yeah, it would be nice to standardize on something...

In terms of system_views.sql, the SQL input files in the regression
test suites and the sample files, we are using whitespaces, not tabs.
I cannot say much about the width part and what would be a good
number, but at least it seems to me that the tabs should go.  We don't
really have a strict width rule for the SQL files in the regression
tests, and I don't think we need one.  It would be nice to keep the
same flexibility for the isolation spec files.
--
Michael

--v87X9NtEWwuOSa/1
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnnDmoACgkQnvQgOdby
QH3VAw//VFDrLrXkOkbPPm51r/zy6o6aIOGOUSTggxjPa5NMIUvea2pasjLEPM78
SJGfspC58Akjt76I9ZZInGSmnB+7sCtc4wQ+P76qwNcsaqXLTVvwCINU7yw91rrO
xZZ2HifnlEv4gxM7Zf9KaLhk+srInj/YP0ekyg1W4hLWEOd+eyfANI1t/jXu7EiV
eRtXPXt6c2efJ+h60To7XwQsAzv3YKAwRCMaBVVGNedtsHN2PLcWMDL8q8sqnTOs
Z8QRbjLgYUyOskAFQUq5aXJmagcmHU2z6pw08zYSP9g5AUQCk3QxqydNoVz0gGa/
Sq4SocsKiOzMHcKXo0QeGJ8oaSHVXSoaJ4aP33hF7QqgVXk5QAuGl/9pVMe8svTm
xMUKP6eeOG3eLL4MxqwxU9fEFFeHP13lJalyU584afg4FrZqvi6/ZO5TRRQ1++QM
Dp8MRqu7xMmuEnFNFrR1/375m+0IcQwhzvuryvcPkmigr0V3n3F3pue1GW5+hT09
pzS8sWgbUS1H2teF6PF75YC953bTXNm7Vuce+YJed3BhxGutTLwB2bkwYEGpO85G
RDPtjkQcJ6nzyh0C7/hCDZCMU7i9LWEdmC/36mFtCouDSXVnub4uUoI0rObC3FHF
2E9TdoDDl4z1g4bIZ8ege/r85+dXEJGNNv3BZHJVrhc7Tq0izSI=
=M04t
-----END PGP SIGNATURE-----

--v87X9NtEWwuOSa/1--