Feedback-ID: ie0a040ee:Fastmail
Message-ID: <aede1a3b-2b87-435d-84bf-eeede3ee95e4@eisentraut.org>
Date: Tue, 14 Jan 2025 10:58:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Virtual generated columns
To: jian he <jian.universality@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 Dean Rasheed <dean.a.rasheed@gmail.com>
References: <a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org>
 <0f811f71-8c86-4e1b-b3bb-6a535674a440@eisentraut.org>
 <CAEZATCU3q=znAL7X1aSxuMpjfSyB1cT5j398HPb9ix9ci_HUqA@mail.gmail.com>
 <cd7c0fea-6c4b-4bdd-af3b-4d4dabb32ca1@eisentraut.org>
 <CAEZATCVLfMzNwT1J0bnvtv6YbmNSN9QSXb+1QSGyX6vK4q67Ow@mail.gmail.com>
 <ef7c466d-e3b9-4d60-bc03-cd9b48581442@eisentraut.org>
 <09800cb1-43aa-4239-8918-46b71ede4900@eisentraut.org>
 <536b281b-2cb3-4477-971f-c64838bc6263@eisentraut.org>
 <CACJufxF8fmM=Dbm4pDFuV_nKGz2-No0k4YifhrF3-rjXTWJM3w@mail.gmail.com>
 <41f64e3c-db80-43b2-9a21-7ecc515f889f@eisentraut.org>
 <c44f28a7-542c-4044-b8b2-d578bd4e9926@eisentraut.org>
 <cfc3106f-40f1-4895-8b8a-873d3cf2db48@eisentraut.org>
 <CACJufxEeUfpUoFng=0Pm0-cJ4rwyBJCv4x_FXmkYqozWB7uvFQ@mail.gmail.com>
 <1662507.1736354338@sss.pgh.pa.us>
 <721f6d40-ac9b-4103-aec8-a664f9e9dc1c@eisentraut.org>
 <CACJufxENbbA_LCnDLd=y3t+mqvcPyQNW__qw3VYQwq3Tkc_JSg@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CACJufxENbbA_LCnDLd=y3t+mqvcPyQNW__qw3VYQwq3Tkc_JSg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/aede1a3b-2b87-435d-84bf-eeede3ee95e4%40eisentraut.org>
Precedence: bulk

On 09.01.25 13:41, jian he wrote:
> we can not ALTER COLUMN DROP EXPRESSION for virtual for now.
> so the following comments in generated_virtual.sql conflict with the output.
> ```
> -- check that dependencies between columns have also been removed
> ALTER TABLE gtest29 DROP COLUMN a;  -- should not drop b
> \d gtest29
> ```
> we can also comment out line 557 in generated_virtual.sql.

Ok will do.

> attach patch is removing unnecessary parentheses from
> ```ereport(ERROR, (errcode```
> only for this patch related.
> per commit https://git.postgresql.org/cgit/postgresql.git/commit/?id=e3a87b4991cc2d00b7a3082abb54c5f12baedfd1
> 
> also https://www.postgresql.org/docs/current/error-message-reporting.html says
>   ""The extra parentheses were required before PostgreSQL version 12,
> but are now optional.""

Right.  I tried to keep it mostly consistent with existing surrounding 
code, but I will do another pass to improve that.