Content-Type: multipart/mixed; boundary="------------xQFBvh0PhJJAOfPDGkXrUxUV"
Message-ID: <aee28ee7-0ab3-c2e2-5bed-109feb0c089b@enterprisedb.com>
Date: Mon, 28 Feb 2022 10:02:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Content-Language: en-US
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: psql: Make SSL info display more compact
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/aee28ee7-0ab3-c2e2-5bed-109feb0c089b%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------xQFBvh0PhJJAOfPDGkXrUxUV
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Currently, when you connect with psql over SSL, you get a display like
this:

psql (15devel)
SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384, bits: 256, compression: off)
Type "help" for help.

Since support for SSL compression has been removed from PostgreSQL, it
doesn't seem sensible to display it anymore.  And while we're there, I
think the bits information is redundant, since it can be derived from
the cipher suite, either because it's part of the name (as in the
example) or by looking it up somewhere.  So I propose that we make this
display a bit more compact like this:

psql (15devel)
SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384)
Type "help" for help.

See attached patch.
--------------xQFBvh0PhJJAOfPDGkXrUxUV
Content-Type: text/plain; charset=UTF-8;
 name="0001-psql-Make-SSL-info-display-more-compact.patch"
Content-Disposition: attachment;
 filename="0001-psql-Make-SSL-info-display-more-compact.patch"
Content-Transfer-Encoding: base64

RnJvbSA2NTA0MmI0MGM4NzRmZjlmMzg3N2U1YmJiMTkxNTMyMWY1NzU5YjY4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogTW9uLCAyOCBGZWIgMjAyMiAwOTo1NDoxNiArMDEwMApTdWJqZWN0
OiBbUEFUQ0hdIHBzcWw6IE1ha2UgU1NMIGluZm8gZGlzcGxheSBtb3JlIGNvbXBhY3QKCkRv
bid0IGRpc3BsYXkgdGhlIHN0YXR1cyBvZiBTU0wgY29tcHJlc3Npb24gYW55bW9yZSwgc2lu
Y2UgaXQgaGFzIGJlZW4KcmVtb3ZlZCBmcm9tIFBvc3RncmVTUUwuICBBbHNvLCByZW1vdmUg
dGhlIGJpdHMgZGlzcGxheSwgc2luY2UgdGhhdApjYW4gYmUgZGVyaXZlZCBmcm9tIHRoZSBj
aXBoZXIgc3VpdGUuCi0tLQogc3JjL2Jpbi9wc3FsL2NvbW1hbmQuYyB8IDEwICsrLS0tLS0t
LS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvc3JjL2Jpbi9wc3FsL2NvbW1hbmQuYyBiL3NyYy9iaW4vcHNxbC9jb21t
YW5kLmMKaW5kZXggMjkyY2ZmNWRmOS4uMjA3NDU3MTdhOCAxMDA2NDQKLS0tIGEvc3JjL2Jp
bi9wc3FsL2NvbW1hbmQuYworKysgYi9zcmMvYmluL3BzcWwvY29tbWFuZC5jCkBAIC0zNjY3
LDIyICszNjY3LDE2IEBAIHByaW50U1NMSW5mbyh2b2lkKQogewogCWNvbnN0IGNoYXIgKnBy
b3RvY29sOwogCWNvbnN0IGNoYXIgKmNpcGhlcjsKLQljb25zdCBjaGFyICpiaXRzOwotCWNv
bnN0IGNoYXIgKmNvbXByZXNzaW9uOwogCiAJaWYgKCFQUXNzbEluVXNlKHBzZXQuZGIpKQog
CQlyZXR1cm47CQkJCQkvKiBubyBTU0wgKi8KIAogCXByb3RvY29sID0gUFFzc2xBdHRyaWJ1
dGUocHNldC5kYiwgInByb3RvY29sIik7CiAJY2lwaGVyID0gUFFzc2xBdHRyaWJ1dGUocHNl
dC5kYiwgImNpcGhlciIpOwotCWJpdHMgPSBQUXNzbEF0dHJpYnV0ZShwc2V0LmRiLCAia2V5
X2JpdHMiKTsKLQljb21wcmVzc2lvbiA9IFBRc3NsQXR0cmlidXRlKHBzZXQuZGIsICJjb21w
cmVzc2lvbiIpOwogCi0JcHJpbnRmKF8oIlNTTCBjb25uZWN0aW9uIChwcm90b2NvbDogJXMs
IGNpcGhlcjogJXMsIGJpdHM6ICVzLCBjb21wcmVzc2lvbjogJXMpXG4iKSwKKwlwcmludGYo
XygiU1NMIGNvbm5lY3Rpb24gKHByb3RvY29sOiAlcywgY2lwaGVyOiAlcylcbiIpLAogCQkg
ICBwcm90b2NvbCA/IHByb3RvY29sIDogXygidW5rbm93biIpLAotCQkgICBjaXBoZXIgPyBj
aXBoZXIgOiBfKCJ1bmtub3duIiksCi0JCSAgIGJpdHMgPyBiaXRzIDogXygidW5rbm93biIp
LAotCQkgICAoY29tcHJlc3Npb24gJiYgc3RyY21wKGNvbXByZXNzaW9uLCAib2ZmIikgIT0g
MCkgPyBfKCJvbiIpIDogXygib2ZmIikpOworCQkgICBjaXBoZXIgPyBjaXBoZXIgOiBfKCJ1
bmtub3duIikpOwogfQogCiAvKgotLSAKMi4zNS4xCgo=

--------------xQFBvh0PhJJAOfPDGkXrUxUV--