Date: Sat, 6 Aug 2022 19:20:25 +0800
From: Zhang Mingli <zmlpostgres@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Message-ID: <aeec12a3-501e-449a-8d25-901c4ff706cf@Spark>
In-Reply-To: <920cf618-daed-4a1f-9984-c43eaaa8debe@Spark>
References: <920cf618-daed-4a1f-9984-c43eaaa8debe@Spark>
Subject: [Code Comments]enum COPY_NEW_FE is removed
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="62ee4e89_515f007c_1b7"
Archived-At: 
 <https://www.postgresql.org/message-id/aeec12a3-501e-449a-8d25-901c4ff706cf%40Spark>
Precedence: bulk

--62ee4e89_515f007c_1b7
Content-Type: multipart/alternative; boundary="62ee4e89_7545e146_1b7"

--62ee4e89_7545e146_1b7
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

Enum COPY_NEW_FE is removed in commit 3174d69fb9.

Should use COPY_FRONTEND instead.

Issue exists on 15 and master.

```
typedef struct CopyFromStateData

- StringInfo fe_msgbuf; /* used if copy_src == COPY_NEW_FE */
+ StringInfo fe_msgbuf; /* used if copy_src == COPY_FRONTEND */

```

Regards,
Zhang Mingli

--62ee4e89_7545e146_1b7
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<html xmlns=3D=22http://www.w3.org/1999/xhtml=22>
<head>
<title></title>
</head>
<body>
<div name=3D=22messageBodySection=22>
<div dir=3D=22auto=22>Hi,<br />
<br />
Enum COPY=5FNEW=5F=46E is removed in commit 3174d69fb9.<br />
<br />
Should use COPY=5F=46RONTEND instead.<br />
<br />
Issue exists on 15 and master.<br />
<br />
=60=60=60<br />
typedef struct Copy=46romStateData<br />
<br />
- StringInfo fe=5Fmsgbuf; /* used if copy=5Fsrc =3D=3D COPY=5FNEW=5F=46E =
*/<br />
+ StringInfo fe=5Fmsgbuf; /* used if copy=5Fsrc =3D=3D COPY=5F=46RONTEND =
*/<br />
<br />
=60=60=60<br /></div>
</div>
<div name=3D=22messageSignatureSection=22><br />
<div class=3D=22match=46ont=22>Regards,
<div dir=3D=22auto=22>Zhang Mingli</div>
</div>
</div>
</body>
</html>

--62ee4e89_7545e146_1b7--

--62ee4e89_515f007c_1b7
Content-Type: application/octet-stream
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="=?utf-8?Q?v-0001-Fix-code-comments-COPY=5FFRONTEND.patch?="

RnJvbSA1ZGE1MjgyY2MyOWU0NWJkYTM1YTZlMjlhZDhmODdkNjc0NWY0ODU2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNaW5nbGkgWmhhbmcgPGF2YW1pbmdsaUBnbWFpbC5jb20+CkRh
dGU6IFNhdCwgNiBBdWcgMjAyMiAxOTowODo0MiArMDgwMApTdWJqZWN0OiBbUEFUQ0ggdm5dIEZp
eCBjb2RlIGNvbW1lbnRzIENPUFlfRlJPTlRFTkQKCkNPUFlfTkVXX0ZFIGlzIHJlbW92ZWQgaW4g
Y29tbWl0IDMxNzRkNjlmYjkuClVzZSBDT1BZX0ZST05URU5EIGluc3RlYWQuCgpCYWNrcGF0Y2gt
dGhyb3VnaDogMTUKRGlzY3Vzc2lvbjogeHh4ClJldmlld2VkLWJ5OiB4eHgKLS0tCiBzcmMvaW5j
bHVkZS9jb21tYW5kcy9jb3B5ZnJvbV9pbnRlcm5hbC5oIHwgMiArLQogMSBmaWxlIGNoYW5nZWQs
IDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUv
Y29tbWFuZHMvY29weWZyb21faW50ZXJuYWwuaCBiL3NyYy9pbmNsdWRlL2NvbW1hbmRzL2NvcHlm
cm9tX2ludGVybmFsLmgKaW5kZXggM2RmMWM1YTk3Yy4uZTM3YzYwMzJhZSAxMDA2NDQKLS0tIGEv
c3JjL2luY2x1ZGUvY29tbWFuZHMvY29weWZyb21faW50ZXJuYWwuaAorKysgYi9zcmMvaW5jbHVk
ZS9jb21tYW5kcy9jb3B5ZnJvbV9pbnRlcm5hbC5oCkBAIC01OCw3ICs1OCw3IEBAIHR5cGVkZWYg
c3RydWN0IENvcHlGcm9tU3RhdGVEYXRhCiAJLyogbG93LWxldmVsIHN0YXRlIGRhdGEgKi8KIAlD
b3B5U291cmNlCWNvcHlfc3JjOwkJLyogdHlwZSBvZiBjb3B5IHNvdXJjZSAqLwogCUZJTEUJICAg
KmNvcHlfZmlsZTsJCS8qIHVzZWQgaWYgY29weV9zcmMgPT0gQ09QWV9GSUxFICovCi0JU3RyaW5n
SW5mbwlmZV9tc2didWY7CQkvKiB1c2VkIGlmIGNvcHlfc3JjID09IENPUFlfTkVXX0ZFICovCisJ
U3RyaW5nSW5mbwlmZV9tc2didWY7CQkvKiB1c2VkIGlmIGNvcHlfc3JjID09IENPUFlfRlJPTlRF
TkQgKi8KIAogCUVvbFR5cGUJCWVvbF90eXBlOwkJLyogRU9MIHR5cGUgb2YgaW5wdXQgKi8KIAlp
bnQJCQlmaWxlX2VuY29kaW5nOwkvKiBmaWxlIG9yIHJlbW90ZSBzaWRlJ3MgY2hhcmFjdGVyIGVu
Y29kaW5nICovCi0tIAoyLjM0LjEKCg==

--62ee4e89_515f007c_1b7--