Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 22 Apr 2026 10:47:56 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Haibo Yan <tristan.yim@gmail.com>, Mohamed ALi <moali.pg@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Fix: Partitioned parent index remains invalid after
 child indexes are repaired
Message-ID: <aegozMN-abH3ki-P@paquier.xyz>
References: 
 <CAGnOmWqi1D9ycBgUeOGf6mOCd2Dcf=6sKhbf4sHLs5xAcKVCMQ@mail.gmail.com>
 <CABXr29GbJe7-vbm0Fn=HWx3vQonwFtv_zO1pSc5FZAvjLuUDVA@mail.gmail.com>
 <CABXr29Epj=23eYAWg_mTdiXYQQzJSVN22uk6tK8ei0ts5wXvSQ@mail.gmail.com>
 <CAA5RZ0s16eHrzcDupipAxC++e-p_n_M7Fpg-MG-V59fB=wykLw@mail.gmail.com>
 <ad1rubGPdHxNnDh5@paquier.xyz>
 <ad5l0sGiJwdkXI-L@paquier.xyz>
 <CAA5RZ0uM7_YPdSahGh1sGeewMb9SzKswyLaZty8aR+a7XpQydQ@mail.gmail.com>
 <aeVSPx7F3ghkZugb@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9BVFPr7BjjB9vRYu"
Content-Disposition: inline
In-Reply-To: <aeVSPx7F3ghkZugb@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/aegozMN-abH3ki-P%40paquier.xyz>
Precedence: bulk


--9BVFPr7BjjB9vRYu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 20, 2026 at 07:07:59AM +0900, Michael Paquier wrote:
> One thing that I'm tempted to add is more scans to check indisvalid
> across these commands, particularly after the individual ATTACH
> PARTITION bits on each individual index.
>=20
> A second thing.  Do you think that it would be worth adding a
> partitioned table that has no leaves in some portion of the test?  I
> was thinking about a partitioned table called idxpart2 attached to
> idxpart in the first part of the test.  I've found this pattern=20
> usually useful for this area of the code when recursing with
> validatePartitionedIndex() from a parent.  I was also thinking about
> a partitioned table idxpart3 in the last test block, but as you want
> to check that indisvalid is not flipped to true for the parent if a
> child is !indisvalid, it would not be adapted.

Both things have been added to the tests, and applied the result down
to v14.  The patch was able to apply cleanly across the board, without
conflicts.  That's rare, these days..
--
Michael

--9BVFPr7BjjB9vRYu
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnoKMwACgkQnvQgOdby
QH0ohg/+Oh4cQ5ix3qmGRFyJ2ugUchHE7NYbSl36ao1K/jKJ55dYD8iZgZRTFWSL
KsD0kTBEyGkNX7MrGup0iWfuYzNrPSJ6kZ+hYZPTm3tMIUMnPTnLioUw979uB00a
NRw9DAFrSwceMXKpotOd4tEGAzRJ5jUtjEvBdf3cArUtL6o4VASI38qPbUJjNofM
h1o9KuHrnLE2nG/81CqW1tIpz62KfTXk/6BSlOZas/HHX4pZAmfaBpE3VKoB6zQ0
9rWSGZZ6Crxbxw2zKg+G5SRkEx3hgUTa5WCg/qjd5JOwStFuQkM32tKy0SNIqHoA
CZFTqg9HAHkTooSXMfpursKHONC0HyWpdEsht0PGUinQaHpwfzIeQIT4iC8KphI/
YtpSycVN/p4x77NZGuWbAtK14ilVlSXweRFMrpPcPcrRvzfSi3qbZU1nLuPx5zDJ
jZnQ/YA88Xh8r+8hxPPLqVbwDgK1bNQbZn020ym4UvC4FXuIzQCWbDDgMlf6S/Yc
gug6IdxbzmmC0HxuCq9t51VnSBC+1axqvWDy22hrr2XBL4cSfEQGfCrYrldXXP5H
1CDo2qIYp7E3jQsE6K9KY6UVSGgCBABwzCw+1D2F+kLpFaNbRdVmpv9pk33/ulv7
Uc6MgGUzKU3BrNssoxYxThsNtOFh1pVex/27xCxn6sR8q2JEhQY=
=5xuC
-----END PGP SIGNATURE-----

--9BVFPr7BjjB9vRYu--