Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 23 Apr 2026 16:22:15 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: CheckAttributeType() forgot to recurse into multiranges
Message-ID: <aenIp7idu8oFmNv6@paquier.xyz>
References: <93ce56cd-02a6-4db1-8224-c8999372facc@iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xSlUz3lx03CgQRqu"
Content-Disposition: inline
In-Reply-To: <93ce56cd-02a6-4db1-8224-c8999372facc@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/aenIp7idu8oFmNv6%40paquier.xyz>
Precedence: bulk


--xSlUz3lx03CgQRqu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 22, 2026 at 11:56:12PM +0300, Heikki Linnakangas wrote:
> That looks like a straightforward oversight in CheckAttributeType(). When
> multiranges were introduced, it didn't get the memo.

Nice catch.

--- this must be rejected to avoid self-inclusion issues:
+-- these must be rejected to avoid self-inclusion issues:
 alter type two_ints add attribute c two_ints_range;
 ERROR:  composite type two_ints cannot be made a member of itself
+alter type two_ints add attribute c two_ints_multirange;
+ERROR:  composite type two_ints cannot be made a member of itself

If you want to create a parallel with multirangetypes.sql, this
choking case may be better if placed there rather than rangetypes.sql,
as it is a multi case.  Not a big deal, still.

> While working on the fix, I noticed that in case of dropped columns,
> CheckAttributeType() is called with InvalidOid. It tolerates that, but it
> seems accidental and it performs a bunch of futile syscache lookups with
> InvalidOid, so it would be better to not do that. The second patch fixes
> that.

This one seems harmless as far as I can see, but we should be careful
to bypass any attisdropped while scanning a set of attributes, so a
backpatch is in order, indeed.  LGTM.
--
Michael

--xSlUz3lx03CgQRqu
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnpyKcACgkQnvQgOdby
QH0Qhg//ShEtbc6zwcdlj8boYXxreAmtGM6uzrNtP3vlQwxPVpwA3vCTshV/S3Pe
nCczIeSOwIq5Oed0xTIMf21sE+Ulk2FcCobi5OnfzUjGtau8MiKYUtwPrkCR/p0+
6fgkJnbOaemztgD6wEnifc40BNGRUo5R0BBp23Z0cAPBdqrmFxTiQrOlxpn1B9MH
oCRdsM6+mjV4iNXgDST8VScdYcZZ/sf0H9SKFkVyg7IIjnflNv6t9hRKVMpLK8mn
kA1ZwdsyUsB9vEWgjcy8GfHlZ7cVlEiFC4DYbgOmcbM0N+Vi2sJg9xLAttPAkpRn
+PqEWzSqngfGDqaokntNjL5Vkyv57XRRv0QDZSmb24vxbyF1RjnMxnl2BsPtclyK
LIG4r31Qs6dfS6Gy7mXXO6BmWAyeGFvKhDGX9FqvYXk2WrBJ57tf8PXbHZfYsJ6u
mKw3Eny2tyB1Wghng75c1HTQQYl2nomWkGtVg4l9a0rInoGxdHhgNaH9RQdAeesC
1SW7GkPoUKnR32nDGQEZXLgOcAAfD9iXAArBRO1eUZW5mC0c1Z268Ow2kIpYTtap
67hAMQWJdWlyPDH9QGOh7rMqAFKN00pvMU5qAV2v6kxGfJxAQYZr8KhW1dyGp+Ou
6XclJRphTtwkmBcJx5wO+KaJzyUmtT8R/VIAMXXXB1vYeQ7pYpQ=
=Rqw0
-----END PGP SIGNATURE-----

--xSlUz3lx03CgQRqu--