Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFojS-005aLH-0b for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2026 07:44:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wFojR-000V5e-07 for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2026 07:44:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFojQ-000V5S-0J for pgsql-hackers@lists.postgresql.org; Thu, 23 Apr 2026 07:44:16 +0000 Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wFojN-00000002NjR-3tHv for pgsql-hackers@postgresql.org; Thu, 23 Apr 2026 07:44:15 +0000 Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfout.phl.internal (Postfix) with ESMTP id 8D03DEC0489; Thu, 23 Apr 2026 03:44:13 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Thu, 23 Apr 2026 03:44:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1776930253; x=1777016653; bh=9719XFSNAr 2zdApVpl05ShE6FUVC2m+/V5b8O7WzJu0=; b=QgzTwzEv3hvUn01HgX8JZmeqEr RJUQY82INEKKA5McvEPgZgO/YQf5g2XxzBXSOFoMCOPuVCBPvuQvWIVTVal5ylZG wLmT3vM6WKzMBLavueGwB62n+AS/KZnExd1Oh1iUGJRF8SjufSw5biRVyOFQdFba c2g6h0n/E2gMHpT5T7Y9gZ5e3eb6S55Bdfg5Jqbe7I4qFtJc/ZFB8RePjPWlRZh4 fh1FkOYyRkZuTPsVdw6946cF6v7Qf2/b5X/grPmcHll/I0Ecg4btOEldn/Bp1BT3 zTUXW58+7gywZtbjyDsGP5weJEV77wgSaZ9l6GD6mQ6tuWyOMW5GuycaKndQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1776930253; x=1777016653; bh=9719XFSNAr2zdApVpl05ShE6FUVC2m+/V5b 8O7WzJu0=; b=pGAKCzEbZ/1/4tCQc1Y9SwaaekMUpbArRJIhDr3bWcpJEEGwhUe fyGFcDo+uDLxmeA27PX9y/Yj82ErzYwc+SvsUMnHZmZR8DDm45ufw/JlX7GZ4Kn8 lV5rNLO1omg6KfnAzyEOyLIeBvxi+lhmVugeuzuwwcdTLmvTzmIFIhi2xY9QjcvR u0UwTTi4CP+hJMu9Y6iZzbfLfAklocf+kGWlFFbVW4zqygZ47w1IJDsig/yPqVVl jPH9l+dENzurIIMHI1YwI53+NWBqU/9q1IjKsQyYFcVy82p8tW5RlMt4h7CwPWgu LAg3DMAmaCNH5C2cOtKw0xvuh5L+mdSESjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdeiieehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtroertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeffudelheeghfekfefgfedthfekuddt vdfhudekgeegheeikefflefhleekheetfeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrnhgurh gvshesrghnrghrrgiivghlrdguvgdprhgtphhtthhopehmrghsrghordhfuhhjihhisehg mhgrihhlrdgtohhmpdhrtghpthhtoheplhhirdgvvhgrnhdrtghhrghosehgmhgrihhlrd gtohhmpdhrtghpthhtohephhgvnhhrihhksedtgiegkedrughkpdhrtghpthhtohepphhg shhqlhdqhhgrtghkvghrshesphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Apr 2026 03:44:11 -0400 (EDT) Date: Thu, 23 Apr 2026 16:44:06 +0900 From: Michael Paquier To: Andres Freund Cc: Fujii Masao , Chao Li , Henrik TJ , PostgreSQL Hackers Subject: Re: Fix memory leak in postmasterMain Message-ID: References: <3e890874-8204-e1c2-8def-3a02cbad2232@0x48.dk> <1658D50F-A8B3-406A-94ED-FA8C7F9DA90B@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pl+h0Nb1U1WaOnVi" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --pl+h0Nb1U1WaOnVi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 22, 2026 at 01:55:36PM -0400, Andres Freund wrote: > If we do it, we should actually be a bit more systematic and also free > output_config_variable. >=20 > ISTM those strdup()s should actually be pstrdup()s? I suspect changing t= hat > would also silence valgrind. I don't see immediately why it would not be OK to maintain this data in the postmaster context. There is no need to rush this change on HEAD, IMO, I'd suggest to leave that as a v20 item.. -- Michael --pl+h0Nb1U1WaOnVi Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnpzcYACgkQnvQgOdby QH3KrA//aJPOitBBtfiBLM0b/NR34CZq6JWNMq0FlYSLcBWaPeZvF7njDWGHwXxa 6GgINDFkRAs7hSPxqMpaQc2kTYoKlB9Z6iCm41OWbB4lM9NDQ1TN+VrL8KgA5WIp POcWMowBVSCKYdu95pZyYCEtEeKYm3L+jqaoyK+2WuIwj75KjNKA8xUtHc1gt8Tt Wor6Oay27JoXONs5Wrn7GWa37OLY6vCAjK0zXVNiTeeK3nyX3y0q+a9f2GMfip02 6XM1hQfDY6eQ5b1+fNwrPTNmEJtf63NT+vYEM4T0JwsGH9gd3I3C2PeWL+f6T8Bf WZd+JDnQM4GHjpV/3IK9FABsMikE+uS93PAQKo6SuBekdZn2mr/kHS3KTF2atSdm s6QC9wNEZUyAZIUhigeZDEbFqrslFCdM3vHK5BxoKWHE75S4ocI2GdoNhs8WU5lF GxroO67AX4iaGKOzbt2EF+eGxnhqRpq0GTU28KCUQzI2LPajSXBJzMb5vd3ydgFL xEPuOjrghifClvRD8u/o8UaP4Z95yULX6WvVWvGZozEbiJDFVzaq+zOgtYl5WqN7 1IfxT45DsiaCfA3Sx2Mnga67pYfWoM/yxSNf/IISxjx0tNebfabi9oLk6+RHMSkM cyoAmnMLxJILXicIrcY3vVTHTa8i4FvdfTKw+1tAW7u4UZgmqJs= =M5oX -----END PGP SIGNATURE----- --pl+h0Nb1U1WaOnVi--