Feedback-ID: ie3de48e3:Fastmail
Date: Thu, 23 Apr 2026 11:25:07 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
Message-ID: <aeniYoOwCQmtWtQW@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="4pbgraihc64wxsmv"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAHut+PuD2pGMEKmk2dFA+guzxBEOas5+=LAm5E+SM2LU35KOnQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aeniYoOwCQmtWtQW%40alvherre.pgsql>
Precedence: bulk


--4pbgraihc64wxsmv
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2026-Apr-23, Peter Smith wrote:

> v2 removes translation of the comma separator, due to the discussion
> over at [1].

Hmm, at least Japanese uses a different character for commas, and
apparently French likes to add a space, so I think this is a bad move.
I think we could handle these things by including the comma together
with the literal in each element of the list being constructed, as in
the attached.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

--4pbgraihc64wxsmv
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-change-translation-markers-in-GetPublicationsStr.patch"