Date: Thu, 23 Apr 2026 13:05:52 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: meson/testwrap: support EXTRA_REGRESS_OPTS environment variable
Message-ID: <aeoZMJxXLpZgla4P@bdtpg>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="3WyonmA85JeTPG5k"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/aeoZMJxXLpZgla4P%40bdtpg>
Precedence: bulk


--3WyonmA85JeTPG5k
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi hackers,

While looking at [1], I did use the pg_regress --use-existing flag that way:

TESTS="test_setup create_index memoize --use-existing" meson test -C meson_build --setup running --suite regress-running

and that produced the desired outcome (i.e running those 3 tests from the regress
suite on a running instance and existing regression database).

That was kind of a trick and not surprisingly when I wanted to run the entire
regress suite that way:

TESTS="--use-existing" meson test -C meson_build --setup running --suite regress-running

things did not work as expected and produced:

1/1 regress-running - postgresql:regress-running/regress        SKIP              0.04s

Ok:                0
Fail:              0
Skipped:           1

means it skipped the tests.

OTOH, with autoconf, one could run:

EXTRA_REGRESS_OPTS="--use-existing" make installcheck

and that would work as expected (means running the entire regress suite on an
existing regression database).

So it looks like that currently (unless I missed it), with meson, it is not
possible to run an entire test suite on a running instance and existing regression
database.

Indeed, setting the TESTS environment variable replaces the schedule and test
list entirely. This means that passing only pg_regress flags (e.g.,
TESTS="--use-existing") results in no tests being run, since no schedule or test
names are included.

The attached patch adds support for EXTRA_REGRESS_OPTS in testwrap. When set,
its contents are appended to the test command for regress, isolation, and ecpg
test types, matching autoconf behavior.

This enables running the full schedule with extra pg_regress options, like:

EXTRA_REGRESS_OPTS="--use-existing" meson test --setup running --suite regress-running

Once we agree on a fix and that fix is pushed, I think it would make sense
to add an example in [2].

[1]: https://postgr.es/m/aekGK/SUIeW5n5fY%40bdtpg
[2]: https://wiki.postgresql.org/wiki/Meson

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--3WyonmA85JeTPG5k
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v1-0001-testwrap-support-EXTRA_REGRESS_OPTS-environment-v.patch"