Feedback-ID: ie3de48e3:Fastmail
Date: Fri, 24 Apr 2026 14:14:30 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
Message-ID: <aeteISM1k7ZtM4Cs@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAHut+Pu7LWQB+m9HTf4nf3BQu8bC_-N5c=kuOf=EHHZE_Ctj9Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aeteISM1k7ZtM4Cs%40alvherre.pgsql>
Precedence: bulk

On 2026-Apr-24, Peter Smith wrote:

> OK. Including the comma within a larger translated string seems like a
> better idea.
> 
> Since you now have the list `length`, I wondered why not simplify
> further to use list_nth indexing? Then you can remove
> `foreach_current_index` and `lc`.

WFM.

> Also, why did you choose to implement `last` versus `first` logic?
> e.g. How about this?

>         {
>             if (first)
>                 appendStringInfo(dest, _("\"%s\""), pubname);
>             else
>                 appendStringInfo(dest, _(", \"%s\""), pubname);
>         }

I don't know, it just seemed more natural.  The whole ", foo" style
simply feels weird to me.  It seems a matter of choice only though, so
if you feel strongly about this, I'm not opposed.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Hay dos momentos en la vida de un hombre en los que no debería
especular: cuando puede permitírselo y cuando no puede" (Mark Twain)