Date: Tue, 6 Feb 2024 20:10:54 +0100
From: Erik Wienhold <ewie@ewie.name>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Maiquel Grassi <grassi@hotmail.com.br>, 
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Psql meta-command conninfo+
Message-ID: <aevq2dxmw2xm2rc3nh2wdcozunipco447mf4rpm7efvqvz4wk2@mo3zmf2ulbzu>
References: <CP8P284MB24965CB63DAC00FC0EA4A475EC462@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM>
 <20240206181919.GA3853632@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240206181919.GA3853632@nathanxps13>
Archived-At: <https://www.postgresql.org/message-id/aevq2dxmw2xm2rc3nh2wdcozunipco447mf4rpm7efvqvz4wk2%40mo3zmf2ulbzu>
Precedence: bulk

On 2024-02-06 19:19 +0100, Nathan Bossart wrote:
> On Tue, Feb 06, 2024 at 05:27:01PM +0000, Maiquel Grassi wrote:
> > postgres=# \conninfo+
> >  Current Connection Information
> >    Attribute    |     Value
> > ----------------+----------------
> >  Database       | postgres
> >  User           | postgres
> >  Server Version | 16.1
> >  Server Address | 192.168.0.5/32
> >  Server Port    | 5433
> >  Client Address | 192.168.0.5/32
> >  Client Port    | 52716
> >  Session PID    | 21624
> > (8 rows)
> 
> My first reaction is that this should instead return a single row with the
> same set of columns for any connection type (the not-applicable ones would
> just be set to NULL).  That would match the other meta-commands like \l and
> \du, and you could still get an expanded display with \x if needed.  Also,
> I think it would simplify the code a bit.

+1 for a single-row result and triggering expanded display with \x for
consistency with other commands.

-- 
Erik