public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: Daniil Davydov <[email protected]>
Cc: Jim Jones <[email protected]>
Cc: Soumya S Murali <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Stepan Neretin <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Mohamed Ali <[email protected]>
Cc: Nazneen Jafri <[email protected]>
Cc: Shawn McCoy <[email protected]>
Subject: Re: Fix bug with accessing to temporary tables of other sessions
Date: Fri, 8 May 2026 15:19:32 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAPpHfdsS49OTo2Af2GeoKJD-1Dy-hOzbje_AWOa_bw5Q9kEi7w@mail.gmail.com>
References: <CAPpHfdvLCgXgdhSvuPCkek+r=P4E-WiNceWfh7UQztiMzfFcvg@mail.gmail.com>
<[email protected]>
<CAPpHfdsOkkeobCfO9hJvaE2fRcdGmWJoX0umx--DnApmtmefCg@mail.gmail.com>
<CAJDiXgjNySH7Od3nZGjWy30sKv+-12c=kajL7Qfkj3y+CDRwtA@mail.gmail.com>
<CAPpHfds8pwuwF69JFs0SQz58op-U4ddR3KWv0NVEij2mpkzgpw@mail.gmail.com>
<[email protected]>
<CAJDiXgi_SW3DVvXb4+n04NA1YfeeXmT3gUnSG7h4JwBd+RdJGg@mail.gmail.com>
<[email protected]>
<CAJDiXgiyy+GG6a5=nDPQeOQTjdQo53+6N0rAzZ=M3baWGPJNsA@mail.gmail.com>
<CAPpHfdsS49OTo2Af2GeoKJD-1Dy-hOzbje_AWOa_bw5Q9kEi7w@mail.gmail.com>
On Thu, May 07, 2026 at 11:04:16AM +0300, Alexander Korotkov wrote:
> Let me do a quick summary:
> * Our buffer manager is not capable for reading temp tables of other sessions.
> * This was covered by explicit checks, but broken since b7b0f3f27241
> introduced alternative code path for reading tables.
> * This doesn't apply to DROP TABLE. DROP TABLE is a conscious
> exclusion and the only operation we can do correctly for other
> session' temp tables. There is an explicit exclusion in the code to
> skip the attempt to cleanup buffers of other session' temp tables.
> * This patchset consists of tests (0001) for various operations with
> other session's temp tables including buggy behavior, and the fix
> (0002) including changes for tests.
>
> Thus, I don't see the reason why this shouldn't be committed and
> backpatched to PG17 (first release containing b7b0f3f27241).
> Opinions? Michael?
Hmm. I don't have any counter-arguments against a backpatch based on
your argument related to b7b0f3f27241. Thanks for reorganizing the
patch set so as the tests happen first, and the changes in the code
become second.
If you wish me to look at this patch set in details, I may be able to
do so around the beginning of next week. I'm not sure that there is a
strong urgency in tackling this issue for this minor release, this
could wait a bit more..
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fix bug with accessing to temporary tables of other sessions
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox