Feedback-ID: i131946ab:Fastmail
Message-ID: <af5567a1-aea6-fbdb-7e4b-d1e23a43c43b@enterprisedb.com>
Date: Wed, 10 May 2023 17:44:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>,
 Mark Dilger <mark.dilger@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: 
 <CANtu0ojS07ptbePVENX9xfb_O8q08AZ64Y3mLCjrx3Gh1+aF5Q@mail.gmail.com>
 <20230108002923.cyoser3ttmt63bfn@awork3.anarazel.de>
 <20230108030956.5q6ptk3boeisibjq@awork3.anarazel.de>
 <20230204105703.gt2j47vdn3s2gylt@alap3.anarazel.de>
 <CAH2-Wzkrh1OmRy=xNQbx4Yb708j152tZ-oPKS1S7fNURVxKTOg@mail.gmail.com>
 <20230206210205.uaaoe2l26fv256hs@awork3.anarazel.de>
 <20230309001558.b7shzvio645ebdta@awork3.anarazel.de>
 <E244808B-83A5-4E50-93BF-DF8D5544505A@enterprisedb.com>
 <20230311232226.fm442j4odhixy75p@awork3.anarazel.de>
 <ED5BB5D4-4C4D-4838-8D42-3A03CFB16791@enterprisedb.com>
 <20230311234121.qnlxuzijeqdxmzu2@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20230311234121.qnlxuzijeqdxmzu2@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/af5567a1-aea6-fbdb-7e4b-d1e23a43c43b%40enterprisedb.com>
Precedence: bulk

On 12.03.23 00:41, Andres Freund wrote:
> Hi,
> 
> On 2023-03-11 15:34:55 -0800, Mark Dilger wrote:
>>> On Mar 11, 2023, at 3:22 PM, Andres Freund <andres@anarazel.de> wrote:
>>>
>>> Something like the attached.
>>
>> I like that your patch doesn't make the test longer.  I assume you've already run the tests and that it works.
> 
> I did check that, yes :). My process of writing perl is certainly, uh,
> iterative. No way I would get anything close to working without testing it.
> 
> CI now finished the tests as well:
> https://cirrus-ci.com/build/6675457702100992
> 
> So I'll go ahead and push that.

There is a small issue with this commit (a4f23f9b3c).

In src/bin/pg_amcheck/t/004_verify_heapam.pl, there is code to detect 
whether the page layout matches expectations and if not it calls plan 
skip_all.

This commit adds a test

is(scalar @lp_off, $ROWCOUNT, "acquired row offsets");

*before* that skip_all call.  This appears to be invalid.  If the 
skip_all happens, you get a complaint like

t/004_verify_heapam.pl (Wstat: 0 Tests: 1 Failed: 0)
   Parse errors: Bad plan.  You planned 0 tests but ran 1.

We could move the is() test after all the skip_all's.  Any thoughts?