Message-ID: <af62f426-85e8-b004-2f38-dec336e6d6d8@xs4all.nl>
Date: Sat, 6 Jun 2026 14:36:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: pgsql: doc: Clarify OAuth validator authn_id logging
To: Daniel Gustafsson <dgustafsson@postgresql.org>,
 pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
References: <E1wVcvV-001Fkp-2Z@gemulon.postgresql.org>
Content-Language: en-US
From: Erik Rijkers <er@xs4all.nl>
In-Reply-To: <E1wVcvV-001Fkp-2Z@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/af62f426-85e8-b004-2f38-dec336e6d6d8%40xs4all.nl>
Precedence: bulk

Op 6/6/26 om 00:22 schreef Daniel Gustafsson:
> doc: Clarify OAuth validator authn_id logging
> 
> Author: Chao Li <lic@highgo.com>
> Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
> Reported-by: Daniel Gustafsson <daniel@yesql.se>
> Discussion: https://postgr.es/m/0281836A-F5FF-41A5-9EE1-656C1FAAC6B2@gmail.com
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/4cb2e2fe0aa8251bef8c2e2351cd5a062c105c0a
> 
> Modified Files
> --------------
> doc/src/sgml/oauth-validators.sgml | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)

Hi,

In doc/src/sgml/oauth-validators.sgml, and if I understand this text 
correctly (always a big if), then:

"If the validator returns true and set result->authn_id then"

should be:
"If the validator returns true and sets result->authn_id then"
   (i.e., set -> sets)

(added Michael in CC as he seems to collect these minimal patches, to be 
committed later as a group)

Thanks,

Erik