Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wHrbH-007Zoe-2Y for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Apr 2026 23:12:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wHrbE-001L5X-1H for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Apr 2026 23:12:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wHrbD-001L5O-2l for pgsql-hackers@lists.postgresql.org; Tue, 28 Apr 2026 23:12:16 +0000 Received: from fhigh-a3-smtp.messagingengine.com ([103.168.172.154]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wHrbA-00000003bga-3046 for pgsql-hackers@lists.postgresql.org; Tue, 28 Apr 2026 23:12:15 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 0E3A11400066; Tue, 28 Apr 2026 19:12:11 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Tue, 28 Apr 2026 19:12:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1777417931; x=1777504331; bh=dAwXpR+XTe lEhauiFu5Z/DFyPaJKDa1OS8XFScSqVEU=; b=lAlg3EOZWKWqIQ4kbUBJQgVpYn moujwmXVcLiCiI4tuD4w6wbvY6n//286Juva0mXLDqa7b4OOZLMX+xYXqqHh+pBQ IuiR3ZMD/5R9YO2XhKrpm8KxT7JFPOnX52LHyg1PlWyr7EKm9B1u4NeRkh94stRW MhOuVulDvA1Yy+FEx9pFpu/XVpCv9pwFs0eCK/qO6gvsB589g7AtGts/yXG+in/2 pHYFayLGJJqXJFrk/yPgOCFh6734Olk47FzBxj/R+AbmrhPFha78sFLapUcTnUL+ 5727bFGwQycWvpKQrhzIeBwYqeCIpOWH3DXBEuVzF/dvfVJQmJZjqcaDSTIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1777417931; x=1777504331; bh=dAwXpR+XTelEhauiFu5Z/DFyPaJKDa1OS8X FScSqVEU=; b=bJnmyf/3FIlR4+4UGm4yS3mMGfqctG1+nsokSBi/KhEx0YZLSZK +65Tw8X4yAxg5SZZ9s/e/Rd9727ZPDJKckb3vvZ7WU7y+eS/7nQWelRB3A40kMXK Pyi6ybOjcCYJyAdKj0pAuS6tppLMgEnSfsB9+GPgSJSuOQklfpfZIT3rpF1z8EOt aqjcvKajxjcr6FRnKKHJsybtMuXvpdH1Op0MhbklEXU0hmlGGXYCHrjj/pUmINFu D04yNLxTwj4jggmG7ASNc3nLSHgzdpTggVa4E7OznhQ4eUOIVlz5iI5xkIwzUxHO wm7C3sbZ7nru2Pf1ER+IBPxIu+hpKzqBsaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdekvdekhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehlohhgvh hinhgvnhhkohdqmhhsseihrghnuggvgidrrhhupdhrtghpthhtohepphhgshhqlhdqhhgr tghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Apr 2026 19:12:09 -0400 (EDT) Date: Wed, 29 Apr 2026 08:12:04 +0900 From: Michael Paquier To: Maksim Logvinenko Cc: "pgsql-hackers@lists.postgresql.org" Subject: Re: Fix the error hint message and test for reset_shared with unknown stats type Message-ID: References: <433431777389005@mail.yandex.ru> <187621777389356@mail.yandex.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3KZsStdynw/IXAF9" Content-Disposition: inline In-Reply-To: <187621777389356@mail.yandex.ru> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --3KZsStdynw/IXAF9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 28, 2026 at 08:18:21PM +0500, Maksim Logvinenko wrote: > The existing error hint message and test were missing the fact that > recently added new lock stats kind. > > @@ -1987,7 +1987,7 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS) > ereport(ERROR, > (errcode(ERRCODE_INVALID_PARAMETER_VALUE), > errmsg("unrecognized reset target: \"%s\"", target), > - errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"recovery_prefetch\", \"slru\", or \"wal\"."))); > + errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"lock\", \"recovery_prefetch\", \"slru\", or \"wal\"."))); Right, thanks for the report, Maksim. I'll fix it later. -- Michael --3KZsStdynw/IXAF9 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnxPsQACgkQnvQgOdby QH2orQ//d+/rHgDsJQxSq2MrgjeHSEZrjuNMFY+BcnjbmZeITSlLIxtMRTRRIvib uHXoDbPQGuuQBzeIrM3+FHFW1PO549vDHA57OfX3sAbxZ6PqezNT0HupRguBqyMj Us8rnDMnjqYIf+jSgr4MjqMjbq8Ygfoe2bpP6m0/JJ8Ri6B+rCMCQ5HAdgqt/H2x rzQJbh549ko0+bvbeM7G5i8bqB10GwO/9c27bpIDckOMerpZnMMVOTYw5xX2+Km2 x5/GPz9llZTOxXS494w7uWrFI86RNtXYRDVlLWwSnLUYegRl6RqJaYZWvajYxdEC x5lr7QcPhAK90f3UWHod1vD4/AiEGSlh4lbIwKisEyUjZMbmIz6rSmLjmaCJcK/P RgS/Jby/WQsE6cDfZS5hpEI5y/+k3QaAvaj4wMsbeigGm7Dljy3AgaQcjQnMWi6D HdlFdwaYVgGLxSbdTS0sXp4o8r3dl0zvv/682GqJNSfrWCSmF7wFscy8ARZzXzT4 Epc4aJxWztxgQvtyIqk5PzAAmT9mt1bpMl43WI2GMkE0XBb4M+oAvtfLLVXw7XaO Hvv9FpTKf3Hs6vrQaK3t0YtlGTpz+9UbpfSfyLltWzJD3PFkjuLguSwuFk22Vkac 8v/pAzkSRPape/DgKDfNCd3SdqECJjsJ+VMGLtIrU4YTcw/+3Mk= =+lfR -----END PGP SIGNATURE----- --3KZsStdynw/IXAF9--