Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wIHRu-007wOy-2V for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Apr 2026 02:48:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wIHRt-005QwY-1x for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Apr 2026 02:48:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wIHRt-005Qw5-10 for pgsql-hackers@lists.postgresql.org; Thu, 30 Apr 2026 02:48:21 +0000 Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wIHRr-00000003RCI-10Yf for pgsql-hackers@lists.postgresql.org; Thu, 30 Apr 2026 02:48:20 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id D2CE81D00228; Wed, 29 Apr 2026 22:48:18 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 29 Apr 2026 22:48:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1777517298; x=1777603698; bh=fdbwMhsFY6 hBZp/aepBBgp4SXgaO8HZMOWA8wx0Xq7I=; b=kzBd8BpskAn5fZ2aXjiNoI1Kz/ bExH4oCa5hj+a96DakOab+dfV8ALoQ4lx10mY3Uv993EXiZ/F6oHldLLA0dbnPzF W88LIzwRKz6gHsT6rJBURPSainNynJ/IV3u6kFdXi9JvfbGiVQ7Mgv0PrJVKx3tJ CejvHpDts3fm5kbekI2z/xdsrbrKLbDlhGaURSrRIBQY5qTlqZanbrJ+k8J7B5OG TpLJ0Y2d11KIJS+cGhz2UOkwv+ZyuT7vvCWP4bM/lDE72gbnoax80lKZ2iwkYaJ6 IZhrksSgJDBFe9SJ9u3CYEsTD03/bDVOMVN3EX3sq9W4sth8qs55/k4M9+pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1777517298; x=1777603698; bh=fdbwMhsFY6hBZp/aepBBgp4SXgaO8HZMOWA 8wx0Xq7I=; b=bQ3GrUw+0MWetfezTNLvwclqtncNxeu7KgXuKLRZ+yvBHgBWBbo A+W2k3p+bvuM3PM5VBQmMsIIUPgZvKY6elXHb0RpQIrLX/YzaH16LycbnLg470X4 +o7ln6NaDHX2/Rek5yWCMMgLyu9G+eNkAXb+bcvUKSpxMnfajzQH64MNUA8nj1Xq pkJX079eNCx1wTjZrMFnP3UuxUo2NxvefCOZQK4Kqsd0T/EaOwIDmgHT0fKbpro0 bmct3/TXFoW3eqsTPbvT9SnZrBFE4sKS0KSGTigHgYq1vwfEWIKqb37N5O20eaNf ZwiPySkTpiEhiv3kXx4OREL/OKkIceXsJUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdekieduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuf fkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgv rhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpe etleeifedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedvjeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvg hlsehprghquhhivghrrdighiiipdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhp ohhuthdprhgtphhtthhopegthhgrrhhshigrmhesghhmrghilhdrtghomhdprhgtphhtth hopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhr gh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Apr 2026 22:48:17 -0400 (EDT) Date: Thu, 30 Apr 2026 11:48:13 +0900 From: Michael Paquier To: DaeMyung Kang Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Fix EINTR retry condition in pg_flush_data sync_file_range path. Message-ID: References: <20260429151811.1810874-1-charsyam@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/5U2PtzIbryGsj0o" Content-Disposition: inline In-Reply-To: <20260429151811.1810874-1-charsyam@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --/5U2PtzIbryGsj0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 30, 2026 at 12:18:11AM +0900, DaeMyung Kang wrote: > While auditing src/backend/storage/file, I spotted a small but > unambiguous bug in pg_flush_data()'s sync_file_range() retry path. > Details below in the commit message; the fix is a one-token change. Ohh, nice catch. This happens to be wrong since 0d369ac65004. -- Michael --/5U2PtzIbryGsj0o Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnywu0ACgkQnvQgOdby QH0iGQ/6AxRM2et4+4b1OLWHGFVRXJZRn4Tlhd/6Iyjd3mrZO2wg2ICnREIECY+q EjFIWlZrx8Ks4q/bP0BRwBW9i9dxt7mbqrbeSwDzeCYh97S+WKsqIXfzQm2INJCZ 8F36Qtx6gAqhU2L6bu1B9J++BQnwUEmnZOjj6mKKzqhS4qBoNGcZmGY15if6IWd8 lXbR1kgvDi8aZ1XCzL3CimYRFu31eSCbE/CHgqqlL2D+dh8SCjpVMq+wKhGhigse 0X6wfv//oIGWPnBqCUhtjQunLDm/V4J2azJ1y9d3S9nbllh6bsCAwCM29lK4Meaj YeHVbDnWsL+0cDSXionxG1kBt3o5T1ok7eVUF0n3qfP9i81rz5CyqPjh9H6TIble mzMu30U/sMwEobcz3WsvSPwX3dreD0w79dzJx5QhAGs+fBXFmoDrpYNh/H0zRTqm RQJi+1xErLKN2ZeT5iuoBw8Vr9kNvMuztKDQJuZHBzyRAgv4xfdFTO7FnJVSgjMF f72jItwezrrbE/ajXA4fG7OAk4EqzBgiYYKoEHWXDfIOfLHi6jupGWcyjSC/A+RZ FCSbhpVrob9QfV9VCdEgz+5NJDu/GVrDwZf1G1No8x7r2zK6w3i1aFSKYVZYyzs3 eymzPEjPAe3LpI5Qk93+aOcYl0VV8V5FMhVRbg6LKFhRRULZu/c= =E7pQ -----END PGP SIGNATURE----- --/5U2PtzIbryGsj0o--