Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wIZTW-008Dme-0s for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Apr 2026 22:03:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wIZTV-00926k-1E for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Apr 2026 22:03:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wIZTU-00926b-2I for pgsql-hackers@lists.postgresql.org; Thu, 30 Apr 2026 22:03:13 +0000 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wIZTS-00000003aTH-1Jr8 for pgsql-hackers@lists.postgresql.org; Thu, 30 Apr 2026 22:03:11 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 536DBEC0181; Thu, 30 Apr 2026 18:03:09 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Thu, 30 Apr 2026 18:03:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1777586589; x= 1777672989; bh=JGorFMPsGa3+1lwz5HMvJ2rxDkfNmR7csJ5SzDN5194=; b=M b0ZGwPEVNdjMmNLPticSxC+UHsuQB81x/CGDGwpY4uiMKj+gohCWPr4fNykZtYAh vRnhphsEyRY1fcrHVe6NbErFrMi9HQDjWQQmR4TVbAeIDk6k0TK6parYBs3qqyHr zSnqKKLKjPzqM4Ua4P6KkJOQsdbH9m6fPmpDaiimqUPRmuo+Uq8hHrYpahRnf89h T/aU1BN7cbTNCkbcgNIPNOABXZ8BNO7Wua/KXspHcedE41oBF7Hw1fVFRljjThxv zmGg2JZdqQ3mlP8QwG3xBsHAidD5HDbnE3oCtpvolzA7t7vXP75GPjnyAlAx5h3c jeR3xLq2caCha+ysQRH5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1777586589; x=1777672989; bh=J GorFMPsGa3+1lwz5HMvJ2rxDkfNmR7csJ5SzDN5194=; b=CmQdXaR/w/kA3xe39 UmUZiwVcxADA+zwBMwSdWUhXsNoBXl0DDRVpQfZ4VNpt/vi8HgQwwPI0jpiWCBXa 2qDyRNOJP8kqwW2ZKpVblWuqx/wotMzFm4h9DZ+IG+ZzotY9koms7aps9y94u+4c 814iNVrheTreXMo7jYBwS/GWX1yqAzbrqa7XFusGLrfD7E7riUDWtpFh5MRjOQ/3 2zHwFmYJWmdqCFNs0J4/kgdNl2fjvD714pA+ub4EwSZfkdG+PjavpCRFBGd61NGv oKtg1QhzBS0HBrLzKqt109FdYjG5m0yaIdkXAbEKvi/nSoz4U4J1i56uwXzJAxAf uQFZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdekkeegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghrohcu jfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgeqnecuggftrf grthhtvghrnhepieehheekkeelgeeuieefvdffgedtudegffehheeffedtudfhtdekfeel leekffejnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvges khhurhhilhgvmhhurdguvgdpnhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtoheprghhsegthigsvghrthgvtgdrrghtpdhrtghpthhtoheplhhirdgv vhgrnhdrtghhrghosehgmhgrihhlrdgtohhmpdhrtghpthhtohepshgrthihrghnrghrlh grphhurhgrmhesghhmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgv rhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtthhopehmihgthh grvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Apr 2026 18:03:08 -0400 (EDT) Received: by ida.kurilemu.internal (Postfix, from userid 1000) id F10ACB03269; Fri, 01 May 2026 00:03:05 +0200 (CEST) Date: Fri, 1 May 2026 00:03:05 +0200 From: Alvaro Herrera To: Antonin Houska Cc: Michael Paquier , SATYANARAYANA NARLAPURAM , "L. pgsql-hackers" , Chao Li Subject: Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <12262.1777187556@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2026-Apr-26, Antonin Houska wrote: > I see you actually refer to the correct tests. I see no failure now as > well. I'll try to make the tests more stable. Sorry for the confusion. So, the reason this wasn't failing for me is that I had default TOAST compression lz4, and the test case wasn't reaching size for being made external, as opposed to pglz. I changed the test to specify pglz compression explicitly. I also added some dropped columns and one more toast column. (On my machine, this expanded test fails for several rows, not just one, when the fix is deactivated.) I fear the buildfarm may end up showing other failures, but there's no way to know other than to try. Thanks, Satya, for reporting the bug. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "In fact, the basic problem with Perl 5's subroutines is that they're not crufty enough, so the cruft leaks out into user-defined code instead, by the Conservation of Cruft Principle." (Larry Wall, Apocalypse 6)