Feedback-ID: ia2694551:Fastmail
Date: Fri, 1 May 2026 09:30:27 +0200
From: 'Alvaro Herrera' <alvherre@alvh.no-ip.org>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Antonin Houska <ah@cybertec.at>,
 Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Message-ID: <afRWQlulXB6R3uNm@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="k6vxbflu22czkb7a"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <OS9PR01MB121498680B79ECB53367E269EF55AA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/afRWQlulXB6R3uNm%40alvherre.pgsql>
Precedence: bulk


--k6vxbflu22czkb7a
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hello,

On 2026-Apr-07, Hayato Kuroda (Fujitsu) wrote:

> 01.
> ```
> --- a/src/backend/access/index/genam.c
> +++ b/src/backend/access/index/genam.c
> @@ -394,6 +394,14 @@ systable_beginscan(Relation heapRelation,
>  	SysScanDesc sysscan;
>  	Relation	irel;
>  
> +	/*
> +	 * If this backend promised that it won't access shared catalogs during
> +	 * logical decoding, this it the right place to verify.
> +	 */
> +	Assert(!HistoricSnapshotActive() ||
> +		   accessSharedCatalogsInDecoding ||
> +		   !heapRelation->rd_rel->relisshared);
> ```
> 
> Not sure it's OK to use Assert(). elog(ERROR) might be better if we want to really
> avoid the case.

How about the attached?

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

--k6vxbflu22czkb7a
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-Turn-protective-Assert-into-elog-ERROR.patch"