public inbox for [email protected]
help / color / mirror / Atom feedFrom: Martín Marqués <[email protected]>
To: David Rowley <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: vacuum_cost_limit doc description patch
Date: Fri, 13 Apr 2018 09:56:18 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKJS1f9ofABS2C=nvpfhsQxZdiR=b_6FjKRnoUkM1wPnzhA+7Q@mail.gmail.com>
References: <CABeG9LtsAVP4waKngUYo-HAiiowcb8xEjQvDDfhX_nFi5SJ4jw@mail.gmail.com>
<CAKJS1f9ofABS2C=nvpfhsQxZdiR=b_6FjKRnoUkM1wPnzhA+7Q@mail.gmail.com>
El 11/04/18 a las 02:04, David Rowley escribió:
> On 11 April 2018 at 09:13, Martín Marqués <[email protected]> wrote:
>> This is a patch to add some further description, plus the upper and
>> lower limits it has.
>
> Hi,
>
> + for vacuum_cost_delay. The parameter can take a value
> between 1 and 10000.
>
> vacuum_cost_delay should be in <varname> tags.
>
> +1 to mentioning that we sleep for vacuum_cost_delay, but I just don't
> see many other GUCs with mention of their supported range.
Thanks David for having a look.
New version attached with the missing <varname> tags.
> effective_io_concurrency mentions the range it supports, but this
> happens to depend on USE_POSIX_FADVISE, which if undefined the maximum
> setting is 0, which means the docs are wrong in some cases on that.
>
> vacuum_cost_limit seems fairly fixed at 0-10000 with no compile-time
> conditions, so perhaps it's okay, providing we remember and update the
> docs if that ever changes.
I'm also adding a second patch over the config.sgml doc to fix what I
believe is a misguidance in the minimum resolution time modern systems have.
The patch just changes *many* for *some* systems which have a minimum
resolution time of 10 milliseconds.
--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: vacuum_cost_limit doc description patch
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox