Date: Mon, 4 May 2026 12:11:23 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Aleksander Alekseev <aleksander@tigerdata.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Message-ID: <afjTOw2fxLkktOsH@nathan>
References: 
 <CAJ7c6TOGdVBK5P-s59c77qxaw=ydPjpzp_s3VbpHeHn3Gc1iyA@mail.gmail.com>
 <aPqPK4ERy5-jj185@nathan>
 <CAJ7c6TMTzQsnKfM+_4i-4WO7=YnV4nO8ABWA6enSpdtg6DKhqQ@mail.gmail.com>
 <aP-H6kSsGOxaB21k@nathan>
 <aQABs_2dbXmGXDvv@paquier.xyz>
 <7415F7DF-FA45-49E1-AC70-04868714DC8A@gmail.com>
 <aTs7A4lbcm0ThXaO@nathan>
 <aYZqyoNlah_E-Zua@nathan>
 <CAJ7c6TPJVau3Ppih7+KubRwvG9CRpXq16L3X9bE02KuGgL95Nw@mail.gmail.com>
 <206322.1777912819@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <206322.1777912819@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/afjTOw2fxLkktOsH%40nathan>
Precedence: bulk

On Mon, May 04, 2026 at 12:40:19PM -0400, Tom Lane wrote:
> Another amusing diff I noticed:
> 
> --- a/src/backend/partitioning/partbounds.c
> +++ b/src/backend/partitioning/partbounds.c
> @@ -5713,7 +5713,7 @@ check_parent_values_in_new_partitions(Relation parent,
>   * 3. In case new partitions don't contain the DEFAULT partition and the
>   *	  partitioned table does not have the DEFAULT partition, the following
>   *	  should be true: the sum of the bounds of new partitions should be equal
> - &	  to the bound of the split partition.
> + * &	  to the bound of the split partition.
>   *
>   * parent:			partitioned table
>   * splitPartOid:	split partition Oid
> 
> Clearly, this is somebody's off-by-one-key typo, and the correct
> fix is s/&/*/.  I suspect that fixing that manually is the most
> expedient answer, rather than trying to make pg_bsd_indent smart
> enough to DTRT.

+1.  This patch has been rather good at finding small mistakes like this,
which I've been manually fixing along the way.

-- 
nathan