Date: Tue, 5 May 2026 16:47:07 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Chao Li <li.evan.chao@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgindent versus struct members and typedefs
Message-ID: <afplW8DvRONDc1yl@nathan>
References: <aS9hkwnkWf3dZIA_@nathan>
 <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com>
 <509793.1764715875@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="k2Vi/uo5iFea1Gni"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <509793.1764715875@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/afplW8DvRONDc1yl%40nathan>
Precedence: bulk


--k2Vi/uo5iFea1Gni
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Tue, Dec 02, 2025 at 05:51:15PM -0500, Tom Lane wrote:
> Chao Li <li.evan.chao@gmail.com> writes:
>> On Dec 3, 2025, at 06:00, Nathan Bossart <nathandbossart@gmail.com> wrote:
>>> I tried to fix pgindent for a few, but the code is basically impenetrable.
>>> I didn't find any fixes upstream [0], either.  As noted above, we could
>>> also fix it by avoiding the naming conflicts.  However, I can't imagine
>>> that's worth the churn, and I've already spent way too much time on this,
>>> so IMHO the best thing to do here is nothing.
> 
>> I think that’s fine.
> 
> Agreed, not worth the trouble to fool with.

For fun, I spent some time with an AI tool to develop the attached fix for
this problem.  The explanation seems reasonable to me, although I am by no
means a pgindent expert.  When I looked at this in December, I did find
this similar commit from upstream [0], but I failed to make the connection
with last_u_d.  0002 is the result of a pgindent run after applying 0001.
You'll notice that it fixes the exact set of cases I found with grep
upthread.

[0] https://github.com/pstef/freebsd_indent/commit/afa2239

-- 
nathan

--k2Vi/uo5iFea1Gni
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v1-0001-pgindent-Fix-spacing-after-when-member-name-match.patch