Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wKe39-001D4u-0F for pgsql-hackers@arkaria.postgresql.org; Wed, 06 May 2026 15:20:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wKe37-0004qw-2p for pgsql-hackers@arkaria.postgresql.org; Wed, 06 May 2026 15:20:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wKe37-0004qn-1u for pgsql-hackers@lists.postgresql.org; Wed, 06 May 2026 15:20:33 +0000 Received: from mail-yx1-xb12c.google.com ([2607:f8b0:4864:20::b12c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wKe35-00000000qQL-1mDu for pgsql-hackers@lists.postgresql.org; Wed, 06 May 2026 15:20:33 +0000 Received: by mail-yx1-xb12c.google.com with SMTP id 956f58d0204a3-6563f83ae9fso7051908d50.1 for ; Wed, 06 May 2026 08:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778080829; x=1778685629; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=87W1coqyjFHNpSWC6rQCEvrb8Au1PxgOxDAhI+D99T4=; b=LORZd73AV/XfQzptNq5bHEn4zUaKapfrD2OY/6W0Itn2pr6Q1tsUWlWPLZfBhq3Kih CYuzFuqoG7epdtSaOfPvDIch4ShRdaV4OHAxHxz170RCwGBJwBwmrsRzfFZ0fLH6tI/x uV30dpwHIolFQFEjsXIpJIqzvghJwcAsdZUR+sA+KPvcwZDFFSpucr26Q9dqoUXIar88 zg3ouqaBQqL3TpjC1Hl+nknkbX1B4vE+1dlcjb0PR9TKHZTIp004H1K5Aoal83Hs7gk2 6dPWOlEhOb1zDGqgj5ny9SVkJ6Qtgnfh/ubn9z0ySIHGjze5ai+X2dl/YwoK/mHatkeh Rp7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778080829; x=1778685629; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=87W1coqyjFHNpSWC6rQCEvrb8Au1PxgOxDAhI+D99T4=; b=MPqfX54QD9aobn7k6RTD10ZEeZ3dx6FKPKgn/sKN1FFKdZNV93TZ+IBPcU/TXBGqhQ gl6+vnDg4adtwA/uQK/VQvZP3FznM/lNBXEOBJoOhFVS0/K5zU5mbpVuI9hMcq6eXv1Z 0UAtIB672kyieGsTsRrMxF1hEnof2S77eE/qWyaIArI66kWp2ux4RJ4+QDx89ID87P9v Qrx+RS7Q9WpbvAo3NxZ97wO/zvklpVxs3mDnyfkYN67Gyi4OxVb5ELguYFlVDPzrUXEr BBdWDqDcmZbwb+Hqktdk7B0XWMzquKYIczdLrRYVJrTUfJlp3y5Ts6jM8arJy8Dnq2JD RtcA== X-Forwarded-Encrypted: i=1; AFNElJ/z6qYcwtxO4mqqagfabAoYlGnZABUgCHPzKtgwG0Z0gGnfZUumDwed+MNpUWvWP/VZZ10P9t9yu16AwcXX@lists.postgresql.org X-Gm-Message-State: AOJu0YylDoEXVTbSRxrk5z9L2y0Uu3CcGPZyeM4Ie4yHCYrqC+alfKK1 AgHjCLUh9m74bKwrUGJhxIxNkEw3mTAWEJJ6NPDx6n80AQIkY9lFYHdv X-Gm-Gg: AeBDiet1GjNeP66Vv4ZBCa1G91vZaIb2dWrQu8yH54+oBAbAa1CT47h5se7JJRzw6eM v9KAt67dRIzG2Ngko9yWwfDcGSLbYdDxvnrb2Dvu4J3HSypLABdiVCba91Ewf1aAIAFYrBJ0KT3 th8pCe3dAvtB7AXfZPKI6wtqUZ1FuJ4H3P/0qSbL9s+UOHQzgoWYXrrjG1tJ0x9sCzuTegs+jJq 295MSMyo9bjWCM0Eb4hZmB+iIWOj74ZtojWcnyib8bK5dSnGYiF+qRJ6qywG93oygFtCWZ0pWbB 7/Mj61C3zMYhNt7HHSRNW6zYMN0yyhdxlsigAvnI7kei+TO791X/vGWnYZiUcUZn8qboF/Uyx06 /wbmmJAGGNb62aO71bFbGVWLN+sDQ9UYwuctrOzDTk8jwG0Jsm5vzA8LS3171vmIPEfYOn1CNZf d9l7y5cjS/tWWZRNJUeRhOni7Oo9TL3IT3aZSE1m2/JkPRLJAN35hC8yEnx8f4oXB9yi0GnsZ3w WfHO8TlLmV2REljTa68+xWUDWudVW8x6c8IM73iXns= X-Received: by 2002:a05:690e:dc4:b0:65d:4429:b6c6 with SMTP id 956f58d0204a3-65d4429dd7dmr193715d50.39.1778080829233; Wed, 06 May 2026 08:20:29 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65c7adc36aesm1190658d50.2.2026.05.06.08.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 08:20:28 -0700 (PDT) Date: Wed, 6 May 2026 10:20:26 -0500 From: Nathan Bossart To: Tom Lane Cc: Chao Li , Rahila Syed , Robert Haas , PostgreSQL Hackers Subject: Re: pgindent versus struct members and typedefs Message-ID: References: <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com> <509793.1764715875@sss.pgh.pa.us> <729177.1778039019@sss.pgh.pa.us> <771696.1778079755@sss.pgh.pa.us> <773076.1778080637@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <773076.1778080637@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, May 06, 2026 at 11:17:17AM -0400, Tom Lane wrote: > Nathan Bossart writes: >> On Wed, May 06, 2026 at 11:02:35AM -0400, Tom Lane wrote: >>> We already have an INDENT_VERSION bump queued for the >>> space-between-comma-and-period change. I don't think we need two >>> bumps in this cycle, as long as we coordinate pushing these changes. > >> Okay. I'll go ahead and commit the patches for $subject then, leaving out >> the version bump. > > No, *don't* do it right now. You'll break anyone using the > in-tree version, or if you also commit the ensuing code changes, > you'll break anyone using an out-of-tree copy. This stuff all > needs to go in at once. Alright. I'll just prepare the patches and post them here for when that time comes, then. -- nathan