Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wL5sK-001WWm-1P for pgsql-hackers@arkaria.postgresql.org; Thu, 07 May 2026 21:03:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wL5sJ-0069wv-17 for pgsql-hackers@arkaria.postgresql.org; Thu, 07 May 2026 21:03:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wL5sI-0069wn-31 for pgsql-hackers@lists.postgresql.org; Thu, 07 May 2026 21:03:15 +0000 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wL5sG-00000000hRd-0Uaf for pgsql-hackers@postgresql.org; Thu, 07 May 2026 21:03:14 +0000 Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-506aa68065eso9094291cf.1 for ; Thu, 07 May 2026 14:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778187792; x=1778792592; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DshBbeAfc8zyqhVURNDBG2oLr7wNEW/8ckHD8bS6hW4=; b=NxMen6EaIdqVZ7ATm8V99nTRZIvmfPs+mTkrK3zIpJJk7hAZouaEGlajxpisg5ZnAR gsWTz5wh2V/Qn4orAIfraDFq6wpdKXeD+f9zn13xsW/NdryEjYFBUbLAHJjng+9EmoNP Atsri89LqinK1xu8Ih6u9u7bcBHjOQz+TZY19RgXNfl6vsyw/K9cXX1IFwqW+JjD7Txb E8WGxzIooRbpLr6Zl6Yu27uTYRlgQdiNPZaCuxMZetexhDgbTLksKFCR9GSydjQqh/jk pfXMc2+JHH72WVrh4E0xEy0fxAbPU3ikIqx9BwWZpiDaq/LZZ5rwEmRsj9FNR/bBfMjS 2Gpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778187792; x=1778792592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DshBbeAfc8zyqhVURNDBG2oLr7wNEW/8ckHD8bS6hW4=; b=RlcnGqw81PjmF4n+NyxaPU1olZl2p8DNK8bl6oFBRTHSwH5JYALq0XMAAB7GxrX7ws VRCOu+uQWAz+r2Cqukup62LJMzIqog1lNx2u/zO7WEpDJQQe06k9oMe9hHAP7Sshedto szB1mHEuqFmDRhmwUO2QfZSdUavAmIU7BEibP+0lBrEVKyiNPoLFtx5kcHFENA23ozhR sSSFxPLbQNQllfLlSrEnKssAEQ+xVEndYt1AAeup9Nhy5W7CWWiIGH4zRkAAekHPvTCu UzwFum+qNBKzLJTgNPv2sGtBVzUrkdN1dh7gEidm3YGlLDqQi6F9enF4rVIURqESTYJI h67w== X-Gm-Message-State: AOJu0YwOVWtoXMGavO1SRdYljoFFBEl1K8x2oBqObQiBWm2/UE9BBzov 07lmhaIS3/8N2UGAGKYKs3p0EfioVfCFCzTCXYZxNhvmCIwSqJC7NSkO X-Gm-Gg: AeBDievQGcQ8xuXDCWOtvSBqzFcyq0TUzh5Gmfel875YBGdZWQG3i66b20suPLtZrcA B7Rz87ztcg61khRdTpGqosHaL/C+HA6DMEKVGTR8U3VaqrxWfvLTmuhLyONmPTyoEZwh/fTOM4Q LRS/KbRnz0hgU9mA0zcsnW21Ux9Refcahqi5u6Ekx7NjeL3e1qcXVSJCHXob/Bx0FCuWmlcF6YS jq3v9tqbDGlFOJcGq4iavSy4hg1MmsLx595LM+88ETwqUWvIpQz61Bx3+DtsExCR+hrUlyBK1HN rJ3iUvXq2CsYMSHQIZugEwM5NYSFjw42Bqps54CNZ0W9GmNmV+6uu9SuexFof/YIsO81ySD3TCR IPjw+xnwcntGSA0mgD3fZZjFAH5ZMnMJRs4OzA+IyVfcQoWSlyvThMdkhzSviVzg5fjVRm51hQA DMxMulSvA9PkoVDPH/Lnf/qt6O9CWngeRRebZe6g0S0CrgUYb3ioMIP7HqNILaQaDjkVbFZK22c 6SJOl6ZOnN4Pisgr379Ug== X-Received: by 2002:a05:622a:408b:b0:50f:ade2:2d3 with SMTP id d75a77b69052e-51461faa8femr133137011cf.42.1778187791560; Thu, 07 May 2026 14:03:11 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-514851141ebsm7216201cf.13.2026.05.07.14.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 14:03:10 -0700 (PDT) Date: Thu, 7 May 2026 16:03:09 -0500 From: Nathan Bossart To: Kirill Reshke Cc: pgsql-hackers@postgresql.org Subject: Re: small cleanup for s_lock.h Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="JmXY/Yn6swRVDyih" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --JmXY/Yn6swRVDyih Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 05, 2026 at 03:20:46AM +0500, Kirill Reshke wrote: > This indeed looks like a dead code. I also noticed `tas.s` is present > in meson.build, gitignore and src/backend/Makefile > should we remove that too? I forgot to remove these in v3. Here's a new patch set with that taken care of. -- nathan --JmXY/Yn6swRVDyih Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=v4-0001-Remove-fallback-declaration-for-tas.patch