Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wPYrq-000q11-1E for pgsql-hackers@arkaria.postgresql.org; Wed, 20 May 2026 04:49:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wPYro-006EAY-0J for pgsql-hackers@arkaria.postgresql.org; Wed, 20 May 2026 04:49:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wPYrn-006EAQ-2d for pgsql-hackers@lists.postgresql.org; Wed, 20 May 2026 04:49:12 +0000 Received: from fout-a3-smtp.messagingengine.com ([103.168.172.146]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wPYrm-00000000UZU-2IVk for pgsql-hackers@lists.postgresql.org; Wed, 20 May 2026 04:49:12 +0000 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id A27ACEC01DF; Wed, 20 May 2026 00:49:08 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 20 May 2026 00:49:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1779252548; x=1779338948; bh=VZFaQawBAD If8IXX2pmExKQsh7RtQmqJ/aS/B5osf8I=; b=ixnY5gqsbDNwn8R0VXbc5PTq9/ Uje1M9TirEhTY+eg2dffLNsC1dSOLX1z/VB/GGeVau+xkXP92a75FxYodlsSgJX5 bQD7Y0qdPAA76kxUwAM1KyZlwfxKu62/Y5o4n8J0slU0z7fsip82IrcsALwA3y6l 8P54p6jefD84WyYaA68B9X74kMT77KNC5qVgjwfXcPBrpMHqan4KM/q8xT9O685/ 8jgaTXXLXIlExVd/pRrgXWAF+SW2VFjCVE+A4xdJ/HRUU2kslvd2omB/Jx2fg8nN sXUr0rzg/04Jbsda3iEvUJ+LxjOQlqGzR5jVeIT5R+glkQlyZ13vDZRx0c2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1779252548; x=1779338948; bh=VZFaQawBADIf8IXX2pmExKQsh7RtQmqJ/aS /B5osf8I=; b=AfWcnMCOa+Dc8Gzuzlmju1uIGOX1CTFVhmR90xJkS/lXmYHEUlL 9yihgO39R0gIn3V5vN3O8eFadXOLClYPjZh6iV9tV1Vudj0rvvts0fD1XO9DBeRe HXIJXvX4XT/+MrzcBrdzOU+WW71sEIjlsQyEGwK5boMViLzyaliVJZG3a7oV+C3W iYotJp9iexMv/pJqIabAiTJQ7tsLnND/3s6PETKiiqARZHEDneK6vzipJaHy4D38 wmMHEkjxGOACs82vKADnI9x9CUX2gfwjkyCHY7BWuStBzj8bb2/xXGhTwvwTCmOD CZiyVGgk8+aLSj3oIlKFeVdv/nn2TFeDnyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddugeefjeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepihhlhi grrdgvvhguohhkihhmohhvsehtrghnthhorhhlrggsshdrtghomhdprhgtphhtthhopehp ghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 May 2026 00:49:07 -0400 (EDT) Date: Wed, 20 May 2026 13:49:03 +0900 From: Michael Paquier To: Ilia Evdokimov Cc: PostgreSQL Hackers Subject: Re: Fix incorrect size check in statext_dependencies_deserialize Message-ID: References: <4b8d299d-2505-4c30-bf80-0f697410db35@tantorlabs.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PA6ZBxSH3Nuwbl+k" Content-Disposition: inline In-Reply-To: <4b8d299d-2505-4c30-bf80-0f697410db35@tantorlabs.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --PA6ZBxSH3Nuwbl+k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2026 at 05:29:56PM +0300, Ilia Evdokimov wrote: > It should use `MinSizeOfItems` instead, which correctly computes the mini= mum > expected size as the header plus `ndeps` minimally-sized dependency items. >=20 > Notably, the similar function for ndistinct extended statistics > `statext_ndistinct_deserialize()` already uses `MinSizeOfItems` correctly, > which suggests this is a typo rather than an intentional choice. Good catch, nice! This looks like a typo from d08c44f7a4ec to me, where MinSizeOfItems sticks to the definition we have for MVDependency in statistics.h. Will fix. -- Michael --PA6ZBxSH3Nuwbl+k Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmoNPT8ACgkQnvQgOdby QH1RCQ//Q3gd+/i9bScwFhD1I7Ng68JGje0kp3dj85+gMRDVWbNSCVoidrVPUPPs CzlSXUsowP3J+pKxrIxZRll2TiJBYDFG+WpgYRxlIxIPDJ8vSL2Ssi+rCgjEbcG9 mOo7Y7FvRejgk5zFiKCmSOe997QmIHlD6QEWytkFcLkG93Sz2GMsEIw8q/XrFMr4 RE7gAF6BGPV0Ze5Nukqpxs6u2e+xybzf9UQT3DyK8anFk/VNSpcHT7jFISEAJYba 9D/IqGS8y0W28pHCF8Jfm5CrIuQTN2pt3uctC4oYW0uo4ASLJP+k2eQ1zp7AEh6n 3AGV7wPxOfPeyj7VrTsIp4sO6SlFHMvyr9+3Q6lfGdybJO3WxrQPtysrw7Cqr9Kq y9rQG6cC6MrKkO1wgST5D4Een5tJBqgaonKgVzh7tF5MYIFCCUrsPDyETpnkbv+o X90bj6nP+OGjyFxB/2NAeZoMLm82FalSs0V55Q5glIywnzY8IgfL7pqXQ0skXYlQ Ukw04aINgbBglpI0IIEPDrQAm5ByTWHPnxqF2FzbTcvZyKKw2D3D+ECpze3SaKZR PYCyvEi8MhsNPwm/OMeeYrrEb+RQw5npasPaXiPbkkH+I4DSCc2MEnwD/tdaiZuF ANpU2/gusTQwyH1KmClb3Kb5XJa1Z5a1k4lV5TuspYlWft7f9yQ= =GuQ5 -----END PGP SIGNATURE----- --PA6ZBxSH3Nuwbl+k--