Feedback-ID: ie3de48e3:Fastmail
Date: Mon, 11 May 2026 18:21:17 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes
Message-ID: <agIBukr85PlM6um_@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7DC152EA-F549-43D1-80ED-4ED2BB6F801E@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/agIBukr85PlM6um_%40alvherre.pgsql>
Precedence: bulk

On 2026-May-11, Chao Li wrote:

> > On May 10, 2026, at 06:38, Álvaro Herrera <alvherre@kurilemu.de> wrote:

> > I think it would be a good idea to make identity_key_equal() not deform
> > all attributes, but instead only up to the last one it needs for the key
> > comparisons.
> 
> That’s true. Please see v3.

Thanks.  I did one further small change, namely to determine these last
attnums just once per run rather than once per tuple.  Pushed now.

Thanks for testing!

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/