Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wOwTN-000Ieg-2H for pgsql-hackers@arkaria.postgresql.org; Mon, 18 May 2026 11:49:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wOwTL-0021a6-1m for pgsql-hackers@arkaria.postgresql.org; Mon, 18 May 2026 11:49:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wOwTL-0021Zy-01 for pgsql-hackers@lists.postgresql.org; Mon, 18 May 2026 11:49:24 +0000 Received: from fhigh-b6-smtp.messagingengine.com ([202.12.124.157]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wOwTI-00000000BDI-40bM for pgsql-hackers@lists.postgresql.org; Mon, 18 May 2026 11:49:23 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 9DC1A7A00A7; Mon, 18 May 2026 07:49:18 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Mon, 18 May 2026 07:49:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm2; t=1779104958; x= 1779191358; bh=MFhynjRXDK39Aj6sbNbN0dq430DE+dGIqFY75NhVaHY=; b=e Hkers0iNaBVeMHlCKyeQxlT6FD8N3NYgsczg1RUhl4jw5DWe+qxwwSkDLCyl/4aS 1R4tBYpyeBo/3wEh1rxzFjE4/E0awQRUFPo8L9gJenQr7tt3CkbW7Jwcy86HiNrM y3nauSJROKGS7L7Aysc9GRFV3gQnxmWXScp98CF4pcRduL0cyBRWKhNDhxYd3h+J AbvlpD2qYF3iHQiWZtgY4SkL0/rEcE91SZZuJQ+Ln2fpWpBkf9ADM3YRIMkJ5B/t oD4eiSGuNr6+Txl8k4vaslhukyF0WLd2CGNODdJml9BiMAVKWMxkFQ5R3cYproJJ YGV59d9xncuj+879mUHDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1779104958; x=1779191358; bh=M FhynjRXDK39Aj6sbNbN0dq430DE+dGIqFY75NhVaHY=; b=R9dZJOQ0m+2p9Kt1i g3BDJwNNXXNFlaSzy2K4p9H2Xw9Jy/VA8AAQIQvxPu0luBSi33fGDt2K7+bX330O aTpOIToPHJPKGfFN+cPxXg+DsGrzZ6ytxo/84EVOTBZnclBwr7I29EBrD+584K1S 8Gkr8GDQ6cGtSCfYPCbYZFZhGRs/EGWcvi6NKib0TMh5NEg6sm0zeoaJpsoo1liA CLspWbLcxsDi2eFjxyMLmAt7Mz5HKWdx9sXkN35NJqsRV6/mpAGRTG6+OPy9IYdi gWzueF6YIf93A+FHMF+6ptq96grV/J0KeTU/1LRVxZBUjyu3AbKGijljCzGwWkuI 9fwBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddufeekjeelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopegsrghjihdrphhguggvvhesghhmrghilhdrtghomhdprhgtphht thhopehmrghsrghordhfuhhjihhisehgmhgrihhlrdgtohhmpdhrtghpthhtohepthhhoh hmsehlihhnuhigrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhi shhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 May 2026 07:49:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1779104954; bh=TmJvtiYmu4IEzWKbl/NVt+CkkycgoINygvFk36xFyG4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=h8bQMrs7MjFM4tEGdS5t0CBaYLPdbpU11p5PfKaX1g5F9V3sbMGWv2Hm217UnBpK2 B0l75eAIUCZinaXNh3JSCwX1qSsrBp5OKziloD2Zh5ip2k+EtU4JE/U8tmbvztbrId DY3P+FOC9Trni3sSqs+m1+h6jr83HDCqG3IDkpt+NhkniBiWRDK6/tFmKw/dUPuRbz OCiqUx8ts9S9TJYOmuu7jPobHvolTozoI4b57gUnVF2nSBmKp5TCwUSG7IoJYbuxYp UooS34O0oDT+Jik9J6n0wCTPPi1kVkqzhPxIeWb7e4EvhWBx3Y4Lo5ekcjlID7SEak fWKYOsqOS+Ayw== Received: by ida.kurilemu.internal (Postfix, from userid 1000) id 1DECDB05EEA; Mon, 18 May 2026 13:49:14 +0200 (CEST) Date: Mon, 18 May 2026 13:49:14 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Thom Brown Cc: Fujii Masao , Baji Shaik , pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Fix psql tab completion for REPACK boolean options Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2026-May-18, Thom Brown wrote: > I saw this just got committed. Is there a reason the option handling > for this, VACUUM, and EXPLAIN aren't done in one place? I don't think they take exactly the same options; but if you see room for improvement, by all means send a patch. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "This is a foot just waiting to be shot" (Andrew Dunstan)