Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 1 Jun 2026 13:37:34 +0900
From: Michael Paquier <michael@paquier.xyz>
To: =?utf-8?B?7Iug7ISx7KSA?= <shinsj4653@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Kirk Wolak <wolakk@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	Andreas Karlsson <andreas@proxel.se>,
	Nikolay Samokhvalov <nik@postgres.ai>
Subject: Re: Add wait events for server logging destination writes
Message-ID: <ah0MjuP8Kku69_vz@paquier.xyz>
References: 
 <CACdN0M78U+GvpqA7oey-GA7fFSYM636aDp6H9FVvCztv9zXxSA@mail.gmail.com>
 <CACdN0M4ENFV0Hg4zbBkP+ScRHdeN9NdYx9QV79h5BM_eN9YxHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="175262D2X04TtRJm"
Content-Disposition: inline
In-Reply-To: 
 <CACdN0M4ENFV0Hg4zbBkP+ScRHdeN9NdYx9QV79h5BM_eN9YxHA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ah0MjuP8Kku69_vz%40paquier.xyz>
Precedence: bulk


--175262D2X04TtRJm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, May 31, 2026 at 07:42:41PM +0900, =EC=8B=A0=EC=84=B1=EC=A4=80 wrote:
> cfbot caught a build failure on v1, in the SanityCheck task on Linux
> and Windows: elog.c uses pgstat_report_wait_start()/end() and the
> WAIT_EVENT_* constants but didn't include utils/wait_event.h. It only
> built here because of an accidental transitive include on my machine;
> on the CI images the declarations weren't visible.
>=20
> v2 fixes that by adding the missing #include "utils/wait_event.h" to
> elog.c, folded into 0001 so that patch builds on its own. No other
> changes; the wait events and the reported write paths are the same as
> in v1.
>=20
> v2-0001 adds the two events and covers the write(2) paths.
> v2-0002 covers the Windows WriteConsoleW() path, split out as before.
>=20
> Applies cleanly on current master; full build passes locally.

Hmm.  Usually we split the event numbers so as there is one for each
code path, but here we are just dealing with the same routine that
sends chunks.  Using the same numbers seem fine by me.

If others have any thoughts or comments, feel free.
--
Michael

--175262D2X04TtRJm
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmodDI4ACgkQnvQgOdby
QH1Mvg/+L+L8pANEQiP2onsh7agPxS9hZQEillY1/NsKZ4pTf/nREzaxV7XbjmHt
zthQ3mqCYaWMa1HG/U8MDfCGY8dtiVjkdAvtt1Dmt0UCBUhGVPzBcQ28bHQgJXgR
6DRjzzf6U26pmBRg/+pIeJBizryfaR4Mm2WEGcU0xzz5FO4IqXROp1AScXWl5e8k
FKG5RNtSjqXySV0/hb15p/GtvDPz7lL84kGg/gXSbh2QBGt2tXiqhgPAP+CGpOHP
r1QFGawxFOHTfVZ7c8vR32+0yTNjftCmjXcBOVrRD/+EnseMDsd3+ODLC0WQYnrQ
YPogOQRH6wxi+Cx+ZVFNfufIVivusuA4jfeEUG+e/RO/8vcQtQ1E5PjshskL0AMK
eS3B5zx6s4YZyIxnM7hsg4MxDife8HzLxQpgzEc43GlJaIkAW/pk9U2B5vgd5iBo
wCL//Dfa3Eb5AgL5DBimxe/1aQw8Pp88v0o8TDdwHApDczeFFmgq8JUG0q2G57ir
ODjfVKk/G+0d1EJuNiyEoK/IPAmmBsVlWaNfd/MiPzRsB/XVT8vXUNqBm6HXQxbV
2ZQk9YZd743B/IAPIWnSSFWYrzp2KgT+GcTtQrbFFjQJNkW8CGZE7Uw82xz6V3BR
GHKu1zJiIoQ8mgsotLn3KCUguH9jv5xDr6Grl6I0WGTcOwQG8tM=
=gA5e
-----END PGP SIGNATURE-----

--175262D2X04TtRJm--