Feedback-ID: ie3de48e3:Fastmail
Date: Sun, 24 May 2026 13:35:59 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: "Jonathan Gonzalez V." <jonathan.abdiel@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: splitting pg_resetwal output strings
Message-ID: <ahLhUNrKB8GyG2cQ@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0357cb9cd9a362662d5d1eb2eb8ef4db1ba18f01.camel@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ahLhUNrKB8GyG2cQ%40alvherre.pgsql>
Precedence: bulk

Hi,

On 2026-May-24, Jonathan Gonzalez V. wrote:

> On a second round a notice these two strings:
> 
> +               char *str = "First log segment after reset";
> +               thislen = internal_wcswidth(_(str), strlen(_(str)),
> encoding);
> +               if (thislen > maxlen)
> 
> and [...]

> Are never catch by the `make update-po` command, instead, the strings
> are there in the `.po.new` file commented.
> 
> Should we put them between `_()`? or is expected that it's being catch
> by the second line with the `_()` ?

Hmm, yeah, they need to be wrapped in gettext_noop() so that they are
not immediately translated (because that will be done by the _() call in
the other lines) but are picked up by msgmerge.  (I think the second one
you reference is "NextXID epoch" but it was victim of a copy-paste
failure.)

Thanks again for looking,

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/