Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 26 May 2026 08:06:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	Alvaro Herrera <alvherre@kurilemu.de>
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and
 -DEXEC_BACKEND at startup
Message-ID: <ahTV4rCj93_CqlDt@paquier.xyz>
References: <ahP-JT4ZRPyobnLb@paquier.xyz>
 <ahQGnTqb7i0UUz70@paquier.xyz>
 <CAJTYsWVuyVK4OTQok2t1=Wz2F5bG+rS6hKuGqK8aBaw-2T7LgA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="61kXE/HJjk4md6VT"
Content-Disposition: inline
In-Reply-To: 
 <CAJTYsWVuyVK4OTQok2t1=Wz2F5bG+rS6hKuGqK8aBaw-2T7LgA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ahTV4rCj93_CqlDt%40paquier.xyz>
Precedence: bulk


--61kXE/HJjk4md6VT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 25, 2026 at 01:54:28PM +0530, Ayush Tiwari wrote:
> So I think the bad assumption is that MyBackendType == B_LOGGER means
> write_syslogger_file() is ready to use.  A fix probably needs to make the
> direct syslogger-file path conditional on the FILE handles being ready, and
> that should cover stderr, CSV and JSON paths.

I am not sure.  We are attempting to write to the syslogger file but
we should not do so yet.  This code path should not be taken and
properly redirected to stderr, we should not use a shortcut based on
the FILE existing or not.

I have forgotten to add Alvaro in CC yesterday, done now.
--
Michael

--61kXE/HJjk4md6VT
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmoU1eIACgkQnvQgOdby
QH2OWg//XiGlkH+MOcCB0QV9/cFjA94Q3XiF7xeHqBNxuYQkx3/KO7DJmPhGtsnz
oKC7goBFqhez2B5/0DZ20WEeaxjZTWVUeDKxS1T53Pq6x+0vaN/kEU8XGeS8kwbB
OtbpFWHimbxuuHwxhGOAzc6HTrFmPEKEaIFwIi6E79XJ3hjoygLj5XTTJTPS2V2k
ZzY5NsQCA/d1JgC0FExVpM3Hbpk39XKk00YpPALEHLJ52V3OeLNkIYPQNj7BZhPI
QbxM420oxcxeLEy1UHHPTHykA387erB++LSGyn8SFwR/+7Dwxv5oJAZwDKlbP/Nw
o2JjG/rDbSPrlmW+obd/VUGGxoyzWYm1uTVU/bOKNksDjng70Z6ygv1/8/ULw0XH
t84Zg8H5danJB75aD751SbuHhDSPjl+8GsxqIho8TZ8rxTBnIfr3eWsMMTcm6gAU
feAYlyD85jBkvlBoqLOr2o/o+EDeGHqyjZeXji/Ya3zfyCOFSWNnChAmXq7rzDGc
4nAXheRKZ1BcZyss6RWR+OAmE/a5YDxy1lX2QHEgVXi3McjLopb4an5GkVN4Jauj
lZwjXS94RCkbey7JervTcYNZoWyhtcruAKNluVtzs/nvTw4ZsH/PdmmGyJJbhnaf
fU1S4Mfykz17oB4X17zdfZzgW5EikQxT7MLz3t8IEW1X31/ML/c=
=+DYM
-----END PGP SIGNATURE-----

--61kXE/HJjk4md6VT--