Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 26 May 2026 08:34:43 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Shruthi Gowda <gowdashru@gmail.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Nishant Sharma <nishant.sharma@enterprisedb.com>,
	Mahendra Singh Thalor <mahi6run@gmail.com>,
	Fujii Masao <masao.fujii@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: [BUG] CRASH: ECPGprepared_statement() and ECPGdeallocate_all()
 when connection is NULL
Message-ID: <ahTckwyxLba5ofwq@paquier.xyz>
References: 
 <CADrsxdbPw1ZYcuqH1-DTNhAvRN=tRTTY+_dFy8wU2g4DQb67Bg@mail.gmail.com>
 <CAASxf_PtXCsmu5oCvZH4BmLdojG+0XJUH8foHFZv+2vmsSbNwA@mail.gmail.com>
 <CADrsxdZMOc6qkoVcyp67+Ez8cesey3iDVaVm617oSpiDdf=5xQ@mail.gmail.com>
 <CAASxf_OkeXLZy6r7f05-LjwxgHEXJymQgifU27CAvWEYfY7uVA@mail.gmail.com>
 <CADrsxdZhGHj96ZYy9GR6U9yLtTshfOU-3DFd0aoz70C5S3Np5g@mail.gmail.com>
 <CAASxf_O+CN9Pw+XSHCbfHE2DwS1BObAwFZnnQyT+7062ozYGQw@mail.gmail.com>
 <CADrsxdb_7nCwjfoFJ3p3QvOyQtZUkDVm0aqX73bWd+27tOTO7w@mail.gmail.com>
 <CAD5tBcL7rMgeykb2ZRF3t00SaWzOhtVME-fDqvspH88d+rosFw@mail.gmail.com>
 <CAHg+QDe=UwWiKo6Yqc5=sUdhG=jm7jWd42yM8iGmadbnU0YNEw@mail.gmail.com>
 <CAASxf_Pd1uXYgjEJW0FftVB560_N7vK_DC6cEhv36vXea186-w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2Fm2oIH7Yno7imsq"
Content-Disposition: inline
In-Reply-To: 
 <CAASxf_Pd1uXYgjEJW0FftVB560_N7vK_DC6cEhv36vXea186-w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ahTckwyxLba5ofwq%40paquier.xyz>
Precedence: bulk


--2Fm2oIH7Yno7imsq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 25, 2026 at 01:16:20PM +0530, Shruthi Gowda wrote:
> Thanks Satya for looking into this. However, we don't need to add the
> validation here because the caller ecpg_do_prologue*()* has already taken
> care of it. Adding it again would be redundant. What do you think?

Right, but I think that this points at a different issue: it is
wasteful to call a second time ecpg_get_connection() to get a
connection while ecpg_do_prologue() has already done a cache lookup
for the connection.

Wouldn't it be better to pass directly the connection obtained by the
first call of ecpg_get_connection() as a function argument of
ecpg_auto_prepare(), replacing the connection name?  If we need the
extra init() at the end, please show if this can go wrong in the shape
of a regression test.
--
Michael

--2Fm2oIH7Yno7imsq
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmoU3JMACgkQnvQgOdby
QH2ySw//SU9m1fOPIGgaPhQd30jgYM+DNGqo5nxA6c/xZle5sYHpFhuZHrIXcX1R
9RMi2EuqJUWEneoWoVHJZYXTjbh1pZD9bRaNQwecrDNeigv5dAnpYMVKRhu4e3NQ
QPyGFl09+c/vHklA/SZbJO5z/7Ypu0yK9pwEBFYBSVUSQQHpbOkRmCKOx6vReSby
ANdNt5jR/bB/rRUEDCPFIuMAvZG2N8GtTcjuapMoy8Tmw+2ncH/YKfbp56g4M4vT
b9WRxCtt9HdbHcRCJ+ZTwtijq592bYiEToogA4va9Py1Ct91eM/bhGMEAYbkYvpl
bgXy4LjoJiVRjDavt1pE9tK+QdRfysOZkKlrF0fSgEHno79b/nziuzIXMGn2FqGi
yyyT3Zmr4zljLOtGx/NqSJUrhs6ANt5yU6JvHKofiW6O3onSij/EJGi5n72TNpGU
KoD643uP8XuNC9vZZDh//4oB1jhqtvxJ0L02f3x6fK6F4xZizpZ6xraIFTVN0kGA
eQjaUB5UAyb/DFozNqY50YWBwB0fdTLE8eKLdzanUT6HwKM6iCojIJLnE6xtx0s5
fLoqZhvOEk5h0oRROSSu8JxK9hOaUOPqIUTW3dags+uMJrNtqqUBgSqZ++do5jUH
B7oNKRxNL19etuWK2KqDins8enzHDaDzhE/yi8fr/Y1PlKGQNvE=
=tAhx
-----END PGP SIGNATURE-----

--2Fm2oIH7Yno7imsq--