Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wRtfp-002mvU-1F for pgsql-hackers@arkaria.postgresql.org; Tue, 26 May 2026 15:26:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wRtfn-004lpB-1C for pgsql-hackers@arkaria.postgresql.org; Tue, 26 May 2026 15:26:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wRtfm-004lp3-21 for pgsql-hackers@lists.postgresql.org; Tue, 26 May 2026 15:26:28 +0000 Received: from fout-a3-smtp.messagingengine.com ([103.168.172.146]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wRtfk-00000001XHq-3BFU for pgsql-hackers@lists.postgresql.org; Tue, 26 May 2026 15:26:27 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id D9897EC0184; Tue, 26 May 2026 11:26:22 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 26 May 2026 11:26:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm2; t=1779809182; x= 1779895582; bh=IKqknHHBq4HLaoNJUrzNWoELmFyTHfHThLgFwznaD5Y=; b=R 9PtcwazJLurmZvBORkDnRXkF6DAn1i5OoufmCmk5qC6LmBjfNodE/DXTSopHGdjr rUxts4H/AavPoSysHZt2itPvzprlCNlLcw/+FyS9v+okNnOJnkE3G69rZ9wI4D73 41UYL1Qqs3gI6QnVl5BoaGFSFrITKIFvDZM9IjsZXDpMA7mzV2PaRfhAFuYMnkG4 INqtCJo2ftXgefYKSEX47dbDDTlsM01IzUqO8rsQi+0m4pScaxh3XyNmpoVxHKxw kXBoiZ95O4nbBlro9otqXDXwJfb9yeFT0pcBB8w6SNrszv2+0FVEw1hMjsDj+LuE tjqIb6ES7/fhWmTCeMd7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1779809182; x=1779895582; bh=I KqknHHBq4HLaoNJUrzNWoELmFyTHfHThLgFwznaD5Y=; b=ad4LbQYQX0MwsgRKD j7oduZvc7SF7fRi81rlj/bV+LTm/KxjESxy7JfwLG3HwixFl06oIHEN1t23Vn9UR GzIOD585cRc/Kty/OdgLj5NNHXy1tE0RKCaRTVE7Mp2eaGny04z7wJNPCOIK01EO +KSip0RFxINorj3mluoegoenn96Oi40iks/IfzO6saG4Nn+T5qQLfpKZvldNeH0f CScjpyRW2DsPr063cNfkDWjojlyEiCL3OdG/RVEKXfX5UsV7++QyWaKY/wfDnX7Z IQ/xJQHg+EsAAjJCA4Ste0VTUWrCqGbZUyNzZXnKsMtw3iq1xbiHKKHxKUFRgA+H Abc5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGRzr3PGyFloC/LB6N6J6GKuZSxIVLjtvlodllGKdAPmx9YxAs7VHYre6UapL9711 J0Xy5DdN2jexehTTpjdx4mmVTVtYVwuXohQ60pPhViLxIFqL5jL4WHO/gAVCVLYprFTxeP rEpdYtU4XStocS+8wkl4sko2g2z33RRst31CfsgUrWmk7xvpClVIhS9C42HQa1nHhoFhTy GbPrKns0osKBBrKI7zzyhAoCrwyZBcfbnBRxfcy7xGe02BSirVFE9JAbukiOVln5+hjYyg URzwKwALFsOWljB1sdG6ilZh06ViGN5/+i/8jOJfkwHTUFSRnpEstKs8jU7wWb9/jd5QBq bZ3pXVMg4iB1XGcNkgAjvG24T5L6Fu+BW3ba4ZtdgCDy8VewUFZZ/EdSaY03PfX/Wce8bY i4FFKOGySEGHkUWh9PmPFtbiSw0Kwp1Q20r05E7uTM/so3giyeWHAT/Z1n5Lzfj6Y7ALEK UD77l9yuCXXe9PsHgFxZl6HXlbQPghrwV9/eDylwJRWbGTueeqszT/e7P6CqSRCxckD5lh lgzUliaM0N6HUyNRQDS/AsPGScjt7RQ0ZRBEDWInFGuV0/g3Fqi0Mh+MbRHQeaE3D4AcRK Lg54hWVbVAF1LCAov5p86Kk5k8DaNXxm/fRijptq9fwv0NNz/b7DbjCeH9mQ X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 May 2026 11:26:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1779809180; bh=ZzscBN81u7gX0F1yGw+Vv7KmRjActcRyunrXaP5ms1A=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=kvVaa+CUf5bMl+wB4pxatLyxTPPAQLNDrMoKPyqnB0/675g30uNTw1DTW48hJEJ3d N6JlxzM7npZotp+0P4L6sqt9QPB8m+m3PUOdlYqoJc6aEr3ulmLKRbBySmC//16GBT 4yD9MW1W4dAObB/KScvDHuzMO1UX/DEiDObaQBLp5a1XGGdmuecC0ydByx/rCkZsWT bR7yjqTiCVg/Cpur+Am+DBBkm1E+b2k2LMkMSLJiFl91hSqgC8exwfCdXxXEuqzY5f ifPIU5lZjZyQTkd5LlyBlc2uTgCjwx54o5+golo8XHDzm6PzPuVZ+Em25HyZh6hecT 2nrnKU6O6G4NA== Received: by ida.kurilemu.internal (Postfix, from userid 1000) id CEB5CB0430D; Tue, 26 May 2026 08:26:20 -0700 (PDT) Date: Tue, 26 May 2026 17:26:20 +0200 From: Alvaro Herrera To: Antonin Houska Cc: Baji Shaik , pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Fix REPACK decoding worker not cleaned up on FATAL exit Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2026-May-20, Alvaro Herrera wrote: > On 2026-May-20, Antonin Houska wrote: > > > The call of shm_mq_detach() got lost, or do you rely on dsm_detach() to call > > shm_mq_detach_callback() ? The latter does not free ->mqh_buffer. > I can put back the shm_mq_detach() call, of course. I did that and pushed. Many thanks! -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Los dioses no protegen a los insensatos. Éstos reciben protección de otros insensatos mejor dotados" (Luis Wu, Mundo Anillo)